Skip to content

Commit 269cb71

Browse files
committed
Fix error logs and variable names
1 parent 046d9df commit 269cb71

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

kafka-connect-oura-source/src/main/java/org/radarbase/connect/rest/oura/OuraSourceTask.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
import org.radarbase.oura.request.OuraRequestGenerator;
4141
import org.radarbase.oura.request.OuraResult;
4242
import org.radarbase.oura.request.OuraResult.Success;
43+
import org.radarbase.oura.request.OuraResult.Error;
44+
import org.radarbase.oura.request.OuraErrorBase;
4345
import org.radarbase.oura.request.RestRequest;
4446
import org.radarbase.oura.route.Route;
4547
import org.radarbase.connect.rest.util.VersionUtil;
@@ -111,7 +113,8 @@ public Stream<SourceRecord> handleRequest(RestRequest req) throws IOException {
111113
key.schema(), key.value(), avro.schema(), avro.value());
112114
});
113115
} else {
114-
logger.warn("Failed to make request: {}", result.toString());
116+
OuraErrorBase e = (OuraErrorBase) ((OuraResult.Error) result).getError();
117+
logger.warn("Failed to make request: {} {} {}", e.getMessage(), e.getCause().toString(), e.getCode());
115118
return Stream.empty();
116119
}
117120
} catch (IOException ex) {
@@ -138,32 +141,33 @@ public void start(Map<String, String> map) {
138141
@Override
139142
public List<SourceRecord> poll() throws InterruptedException {
140143
long requestsGenerated = 0;
141-
List<SourceRecord> requests = Collections.emptyList();
144+
List<SourceRecord> sourceRecords = Collections.emptyList();
142145

143146
do {
144147
Map<String, String> configs = context.configs();
145148
Iterator<? extends RestRequest> requestIterator = this.requests()
146149
.iterator();
147150

148151

149-
while (requests.isEmpty() && requestIterator.hasNext()) {
152+
while (sourceRecords.isEmpty() && requestIterator.hasNext()) {
150153
RestRequest request = requestIterator.next();
151154

152155
logger.info("Requesting {}", request.getRequest().url());
153156
requestsGenerated++;
154157

155158
try {
156-
requests = this.handleRequest(request)
159+
sourceRecords = this.handleRequest(request)
157160
.collect(Collectors.toList());
158161
} catch (IOException ex) {
159162
logger.warn("Failed to make request: {}", ex.toString());
160163
}
161164
}
162-
} while (requests.isEmpty());
165+
} while (sourceRecords.isEmpty());
163166

164-
logger.info("Processed {} records from {} URLs", requests.size(), requestsGenerated);
165167

166-
return requests;
168+
logger.info("Processed {} records from {} URLs", sourceRecords.size(), requestsGenerated);
169+
170+
return sourceRecords;
167171
}
168172

169173
@Override

0 commit comments

Comments
 (0)