Add isComplete to User

Author: yatharthranjan

kafka-connect-fitbit-source/src/main/java/org/radarbase/connect/rest/fitbit/user/ServiceUserRepository.java

@@ -96,13 +96,10 @@ public Stream<? extends User> stream() throws IOException {
     Request request = requestFor("users" + "?source-type=FitBit").build();
     this.timedCachedUsers =
         this.<Users>makeRequest(request, USER_LIST_READER).getUsers().stream()
-            .filter(u -> containedUsers.isEmpty() || containedUsers.contains(u.getId()))
-            .filter( // Filter for when a partial update is ongoing
-                (User u) ->
-                    u.getEndDate() != null
-                        && u.getStartDate() != null
-                        && u.getProjectId() != null
-                        && u.getUserId() != null)
+            .filter(
+                u ->
+                    (containedUsers.isEmpty() || containedUsers.contains(u.getId()))
+                        && u.isComplete())
             .collect(Collectors.toSet());
 
     return this.timedCachedUsers.stream();

kafka-connect-fitbit-source/src/main/java/org/radarbase/connect/rest/fitbit/user/User.java

@@ -23,18 +23,32 @@
 import org.radarcns.kafka.ObservationKey;
 
 public interface User {
+  static SchemaAndValue computeObservationKey(AvroData avroData, User user) {
+    return avroData.toConnectData(
+        ObservationKey.getClassSchema(),
+        new ObservationKey(user.getProjectId(), user.getUserId(), user.getSourceId()));
+  }
+
   String getId();
+
   String getExternalUserId();
+
   String getProjectId();
+
   String getUserId();
+
   Instant getStartDate();
+
   Instant getEndDate();
+
   String getSourceId();
+
   SchemaAndValue getObservationKey(AvroData avroData);
 
-  static SchemaAndValue computeObservationKey(AvroData avroData, User user) {
-    return avroData.toConnectData(
-          ObservationKey.getClassSchema(),
-          new ObservationKey(user.getProjectId(), user.getUserId(), user.getSourceId()));
+  default Boolean isComplete() {
+    return getEndDate() != null
+        && getStartDate() != null
+        && getProjectId() != null
+        && getUserId() != null;
   }
 }