Ensure that client secret is not leaked

blootsvoets · blootsvoets · commit e8e7083cbd70 · 2020-06-17T15:02:00.000+02:00
diff --git a/kafka-connect-fitbit-source/src/main/java/org/radarbase/connect/rest/fitbit/FitbitRestSourceConnectorConfig.java b/kafka-connect-fitbit-source/src/main/java/org/radarbase/connect/rest/fitbit/FitbitRestSourceConnectorConfig.java
@@ -269,7 +269,7 @@ public String toString() {
             FITBIT_USER_REPOSITORY_CLIENT_ID_DISPLAY)
 
         .define(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG,
-            Type.STRING,
+            Type.PASSWORD,
             "",
             Importance.MEDIUM,
             FITBIT_USER_REPOSITORY_CLIENT_SECRET_DOC,
@@ -499,7 +499,7 @@ public String getFitbitUserRepositoryClientId() {
   }
 
   public String getFitbitUserRepositoryClientSecret() {
-    return getString(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG);
+    return getPassword(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG).value();
   }
 
   public URL getFitbitUserRepositoryTokenUrl() {

Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ public String toString() {`
`269`	`269`	`FITBIT_USER_REPOSITORY_CLIENT_ID_DISPLAY)`
`270`	`270`
`271`	`271`	`.define(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG,`
`272`		`- Type.STRING,`
	`272`	`+ Type.PASSWORD,`
`273`	`273`	`"",`
`274`	`274`	`Importance.MEDIUM,`
`275`	`275`	`FITBIT_USER_REPOSITORY_CLIENT_SECRET_DOC,`
`@@ -499,7 +499,7 @@ public String getFitbitUserRepositoryClientId() {`
`499`	`499`	`}`
`500`	`500`
`501`	`501`	`public String getFitbitUserRepositoryClientSecret() {`
`502`		`- return getString(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG);`
	`502`	`+ return getPassword(FITBIT_USER_REPOSITORY_CLIENT_SECRET_CONFIG).value();`
`503`	`503`	`}`
`504`	`504`
`505`	`505`	`public URL getFitbitUserRepositoryTokenUrl() {`