Skip to content

Commit b844fe6

Browse files
author
ewelinagr
committed
Remove unnecessary sentry helper variables, update sentry name and release.
1 parent 7562af7 commit b844fe6

File tree

24 files changed

+26
-194
lines changed

24 files changed

+26
-194
lines changed

charts/app-config/templates/_helpers.tpl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -84,17 +84,3 @@ Create the name of the service account to use
8484
{{ default "default" .Values.serviceAccount.name }}
8585
{{- end -}}
8686
{{- end -}}
87-
88-
{{/*
89-
Service name to be used by Sentry
90-
*/}}
91-
{{- define "app-config.sentryName" -}}
92-
{{- printf "%s" (include "app-config.fullname" .) -}}
93-
{{- end -}}
94-
95-
{{/*
96-
App release to be used by Sentry
97-
*/}}
98-
{{- define "app-config.sentryRelease" -}}
99-
{{- printf "%s" .Chart.AppVersion -}}
100-
{{- end -}}

charts/app-config/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ spec:
9090
value: {{ .Values.sentry.stacktrace.packages}}
9191
{{- end }}
9292
- name: SENTRY_NAME
93-
value: {{ include "app-config.sentryName" . }}
93+
value: {{ .Values.sentry.service.name | default (include "app-config.fullname" .) }}
9494
- name: SENTRY_RELEASE
95-
value: {{ include "app-config.sentryRelease" . }}
95+
value: {{ .Values.sentry.service.release | default (printf "%s-%s" .Chart.Version .Chart.AppVersion) }}
9696
- name: SENTRY_ENVIRONMENT
9797
value: {{ .Values.sentry.service.environment }}
9898
{{- else }}

charts/catalog-server/templates/_helpers.tpl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,3 @@ Create chart name and version as used by the chart label.
5454
{{- define "catalog-server.saslJaasConfig" -}}
5555
{{- printf "org.apache.kafka.common.security.plain.PlainLoginModule required username='%s' password='%s';" .apiKey .apiSecret | b64enc | quote -}}
5656
{{- end -}}
57-
58-
{{/*
59-
Service name to be used by Sentry
60-
*/}}
61-
{{- define "catalog-server.sentryName" -}}
62-
{{- printf "%s" (include "catalog-server.fullname" .) -}}
63-
{{- end -}}
64-
65-
{{/*
66-
App release to be used by Sentry
67-
*/}}
68-
{{- define "catalog-server.sentryRelease" -}}
69-
{{- printf "%s" .Chart.AppVersion -}}
70-
{{- end -}}

charts/catalog-server/templates/deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ spec:
9696
value: {{ .Values.sentry.stacktrace.packages}}
9797
{{- end }}
9898
- name: SENTRY_NAME
99-
value: {{ include "catalog-server.sentryName" . }}
99+
value: {{ .Values.sentry.service.name | default (include "catalog-server.fullname" .) }}
100100
- name: SENTRY_RELEASE
101-
value: {{ include "catalog-server.sentryRelease" . }}
101+
value: {{ .Values.sentry.service.release | default (printf "%s-%s" .Chart.Version .Chart.AppVersion) }}
102102
- name: SENTRY_ENVIRONMENT
103103
value: {{ .Values.sentry.service.environment }}
104104
{{- else }}
@@ -137,9 +137,9 @@ spec:
137137
value: {{ .Values.sentry.stacktrace.packages}}
138138
{{- end }}
139139
- name: SENTRY_NAME
140-
value: {{ include "catalog-server.sentryName" . }}
140+
value: {{ .Values.sentry.service.name | default (include "catalog-server.fullname" .) }}
141141
- name: SENTRY_RELEASE
142-
value: {{ include "catalog-server.sentryRelease" . }}
142+
value: {{ .Values.sentry.service.release | default (printf "%s-%s" .Chart.Version .Chart.AppVersion) }}
143143
- name: SENTRY_ENVIRONMENT
144144
value: {{ .Values.sentry.service.environment }}
145145
{{- else }}

charts/data-dashboard-backend/templates/_helpers.tpl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,3 @@ Selector labels
7171
app.kubernetes.io/name: {{ include "data-dashboard-backend.name" . }}
7272
app.kubernetes.io/instance: {{ .Release.Name }}
7373
{{- end }}
74-
75-
{{/*
76-
Service name to be used by Sentry
77-
*/}}
78-
{{- define "data-dashboard-backend.sentryName" -}}
79-
{{- printf "%s" (include "data-dashboard-backend.fullname" .) -}}
80-
{{- end -}}
81-
82-
{{/*
83-
App release to be used by Sentry
84-
*/}}
85-
{{- define "data-dashboard-backend.sentryRelease" -}}
86-
{{- printf "%s" .Chart.AppVersion -}}
87-
{{- end -}}

charts/data-dashboard-backend/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ spec:
6464
value: {{ .Values.sentry.stacktrace.packages}}
6565
{{- end }}
6666
- name: SENTRY_NAME
67-
value: {{ include "data-dashboard-backend.sentryName" . }}
67+
value: {{ .Values.sentry.service.name | default (include "data-dashboard-backend.fullname" .) }}
6868
- name: SENTRY_RELEASE
69-
value: {{ include "data-dashboard-backend.sentryRelease" . }}
69+
value: {{ .Values.sentry.service.release | default (printf "%s-%s" .Chart.Version .Chart.AppVersion) }}
7070
- name: SENTRY_ENVIRONMENT
7171
value: {{ .Values.sentry.service.environment }}
7272
{{- else }}

charts/management-portal/templates/_helpers.tpl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,3 @@ Return true if a secret object should be created
7272
{{- true -}}
7373
{{- end -}}
7474
{{- end -}}
75-
76-
{{/*
77-
Service name to be used by Sentry
78-
*/}}
79-
{{- define "management-portal.sentryName" -}}
80-
{{- printf "%s" (include "management-portal.fullname" .) -}}
81-
{{- end -}}
82-
83-
{{/*
84-
App release to be used by Sentry
85-
*/}}
86-
{{- define "management-portal.sentryRelease" -}}
87-
{{- printf "%s" .Chart.AppVersion -}}
88-
{{- end -}}

charts/management-portal/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,9 @@ spec:
154154
value: {{ .Values.sentry.stacktrace.packages}}
155155
{{- end }}
156156
- name: SENTRY_NAME
157-
value: {{ include "management-portal.sentryName" . }}
157+
value: {{ .Values.sentry.service.name | default (include "management-portal.fullname" .) }}
158158
- name: SENTRY_RELEASE
159-
value: {{ include "management-portal.sentryRelease" . }}
159+
value: {{ .Values.sentry.service.release | default (printf "%s-%s" .Chart.Version .Chart.AppVersion) }}
160160
- name: SENTRY_ENVIRONMENT
161161
value: {{ .Values.sentry.service.environment }}
162162
{{- else }}

charts/radar-appserver/templates/_helpers.tpl

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,3 @@ Selector labels
7272
app.kubernetes.io/name: {{ include "radar-appserver.name" . }}
7373
app.kubernetes.io/instance: {{ .Release.Name }}
7474
{{- end }}
75-
76-
{{/*
77-
Service name to be used by Sentry
78-
*/}}
79-
{{- define "radar-appserver.sentryName" -}}
80-
{{- printf "%s" (include "radar-appserver.fullname" .) -}}
81-
{{- end -}}
82-
83-
{{/*
84-
App release to be used by Sentry
85-
*/}}
86-
{{- define "radar-appserver.sentryRelease" -}}
87-
{{- printf "%s" .Chart.AppVersion -}}
88-
{{- end -}}

charts/radar-appserver/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,9 @@ spec:
151151
value: {{ .Values.sentry.stacktrace.packages}}
152152
{{- end }}
153153
- name: SENTRY_NAME
154-
value: {{ include "radar-appserver.sentryName" . }}
154+
value: {{ .Values.sentry.service.name | default (include "radar-appserver.fullname" .) }}
155155
- name: SENTRY_RELEASE
156-
value: {{ include "radar-appserver.sentryRelease" . }}
156+
value: {{ .Values.sentry.service.release | default (printf "%s-%s" .Chart.Version .Chart.AppVersion) }}
157157
- name: SENTRY_ENVIRONMENT
158158
value: {{ .Values.sentry.service.environment }}
159159
{{- else }}

0 commit comments

Comments
 (0)