Skip to content

Commit 8bd3bb3

Browse files
committed
Added more unit tests
1 parent 72a2d98 commit 8bd3bb3

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

src/main/java/org/radarbase/output/path/FormattedPathFactory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ open class FormattedPathFactory : RecordPathFactory() {
9090
internal const val DEFAULT_FORMAT_PLUGINS = "fixed time key value"
9191
private val logger = LoggerFactory.getLogger(FormattedPathFactory::class.java)
9292

93-
private fun String.toPathFormatterPlugin(): PathFormatterPlugin? = when (this) {
93+
internal fun String.toPathFormatterPlugin(): PathFormatterPlugin? = when (this) {
9494
"fixed" -> FixedPathFormatterPlugin()
9595
"time" -> TimePathFormatterPlugin()
9696
"key" -> KeyPathFormatterPlugin()

src/test/java/org/radarbase/output/path/FormattedPathFactoryTest.kt

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
package org.radarbase.output.path
22

3+
import org.hamcrest.MatcherAssert.assertThat
4+
import org.hamcrest.Matchers.instanceOf
5+
import org.hamcrest.Matchers.nullValue
36
import org.junit.jupiter.api.Assertions.assertEquals
47
import org.junit.jupiter.api.Test
58
import org.junit.jupiter.api.assertThrows
9+
import org.radarbase.output.path.FormattedPathFactory.Companion.toPathFormatterPlugin
610
import org.radarcns.kafka.ObservationKey
711
import org.radarcns.passive.phone.PhoneLight
812
import java.nio.file.Paths
913
import java.time.Instant
14+
import kotlin.reflect.jvm.jvmName
1015

1116
internal class FormattedPathFactoryTest {
1217
@Test
@@ -99,4 +104,25 @@ internal class FormattedPathFactoryTest {
99104
)
100105
extension = ".csv.gz"
101106
}
107+
108+
@Test
109+
fun testNamedPluginCreate() {
110+
assertThat("fixed".toPathFormatterPlugin(), instanceOf(FixedPathFormatterPlugin::class.java))
111+
assertThat("time".toPathFormatterPlugin(), instanceOf(TimePathFormatterPlugin::class.java))
112+
assertThat("key".toPathFormatterPlugin(), instanceOf(KeyPathFormatterPlugin::class.java))
113+
assertThat("value".toPathFormatterPlugin(), instanceOf(ValuePathFormatterPlugin::class.java))
114+
}
115+
116+
@Test
117+
fun testBadPluginCreate() {
118+
assertThat("unknown".toPathFormatterPlugin(), nullValue())
119+
}
120+
121+
@Test
122+
fun testClassPathPluginCreate() {
123+
assertThat(
124+
FixedPathFormatterPlugin::class.jvmName.toPathFormatterPlugin(),
125+
instanceOf(FixedPathFormatterPlugin::class.java),
126+
)
127+
}
102128
}

0 commit comments

Comments
 (0)