Merge branch 'main' into codex/refactor-contains_nocase-for-performance

Author: RAprogramm

CHANGELOG.md

@@ -5,14 +5,18 @@ All notable changes to this project will be documented in this file.
 
 ## [0.10.7] - 2025-10-24
 
+### Tests
+- Added regression coverage for long classifier needles to exercise the
+  heap-allocation fallback.
+
 ### Changed
-- Precomputed lowercase Turnkey classifier needles with a stack-backed buffer
+- Added an owning `From<AppError>` conversion for `ErrorResponse` and updated the
+  Axum adapter to use it, eliminating redundant clones when building HTTP error
+  bodies.
+ - Precomputed lowercase Turnkey classifier needles with a stack-backed buffer
   to remove repeated transformations while keeping the common zero-allocation
   path for short patterns.
 
-### Tests
-- Added regression coverage for long classifier needles to exercise the
-  heap-allocation fallback.
 
 ## [0.10.6] - 2025-09-21
 

src/convert/axum.rs

@@ -77,7 +77,7 @@ impl IntoResponse for AppError {
         #[cfg(feature = "serde_json")]
         {
             // Build the stable wire contract (includes `code`).
-            let body: ErrorResponse = (&self).into();
+            let body: ErrorResponse = self.into();
             return body.into_response();
         }
 

src/response/mapping.rs

@@ -13,6 +13,33 @@ impl Display for ErrorResponse {
     }
 }
 
+impl From<AppError> for ErrorResponse {
+    fn from(err: AppError) -> Self {
+        let AppError {
+            kind,
+            message,
+            retry,
+            www_authenticate
+        } = err;
+
+        let status = kind.http_status();
+        let code = AppCode::from(kind);
+        let message = match message {
+            Some(msg) => msg.into_owned(),
+            None => String::from("An error occurred")
+        };
+
+        Self {
+            status,
+            code,
+            message,
+            details: None,
+            retry,
+            www_authenticate
+        }
+    }
+}
+
 impl From<&AppError> for ErrorResponse {
     fn from(err: &AppError) -> Self {
         let status = err.kind.http_status();

src/response/tests.rs

@@ -147,6 +147,30 @@ fn from_app_error_uses_default_message_when_none() {
     assert_eq!(e.message, "An error occurred");
 }
 
+#[test]
+fn from_owned_app_error_moves_message_and_metadata() {
+    let err = AppError::unauthorized(String::from("owned message"))
+        .with_retry_after_secs(5)
+        .with_www_authenticate("Bearer");
+
+    let resp: ErrorResponse = err.into();
+
+    assert_eq!(resp.status, 401);
+    assert!(matches!(resp.code, AppCode::Unauthorized));
+    assert_eq!(resp.message, "owned message");
+    assert_eq!(resp.retry.unwrap().after_seconds, 5);
+    assert_eq!(resp.www_authenticate.as_deref(), Some("Bearer"));
+}
+
+#[test]
+fn from_owned_app_error_defaults_message_when_absent() {
+    let resp: ErrorResponse = AppError::bare(AppErrorKind::Internal).into();
+
+    assert_eq!(resp.status, 500);
+    assert!(matches!(resp.code, AppCode::Internal));
+    assert_eq!(resp.message, "An error occurred");
+}
+
 // --- Display formatting --------------------------------------------------
 
 #[test]