Fix for issue #4

Author: gjhiggins

rdflib_sqlalchemy/SQLAlchemy.py

@@ -861,7 +861,6 @@ def open(self, configuration, create=True):
                 c.execute(CREATE_QUOTED_STATEMENTS_TABLE % (self._internedId))
                 c.execute(CREATE_NS_BINDS_TABLE % (self._internedId))
                 c.execute(CREATE_LITERAL_STATEMENTS_TABLE % (self._internedId))
-                trans.commit()
                 for tblName, indices in [
                         (
                             "%s_asserted_statements",
@@ -1676,8 +1675,8 @@ def rollback(self):
     object        text,
     context       text not NULL,
     termComb      integer not NULL,
-    objLanguage   varchar(3),
-    objDatatype   text)"""
+    objLanguage   varchar(255),
+    objDatatype   varchar(255))"""
 
 CREATE_QUOTED_STATEMENTS_TABLE = """
 CREATE TABLE %s_quoted_statements (
@@ -1686,8 +1685,8 @@ def rollback(self):
     object        text,
     context       text not NULL,
     termComb      integer not NULL,
-    objLanguage   varchar(3),
-    objDatatype   text)"""
+    objLanguage   varchar(255),
+    objDatatype   varchar(255))"""
 
 CREATE_NS_BINDS_TABLE = """
 CREATE TABLE %s_namespace_binds (

test/test_sqlalchemy_mysql.py

@@ -50,8 +50,30 @@ def tearDown(self):
     def testLenInMultipleContexts(self):
         raise SkipTest("Known issue.")
 
+
+class SQLAMySQLIssueTestCase(unittest.TestCase):
+    storetest = True
+    storename = "SQLAlchemy"
+    uri = sqlalchemy_url
+
+    def test_issue_4(self):
+        from rdflib.graph import ConjunctiveGraph as Graph
+        from rdflib.store import NO_STORE, VALID_STORE
+        from rdflib.term import URIRef
+
+        ident = URIRef("rdflib_test")
+        g = Graph(store="SQLAlchemy", identifier=ident)
+        rt = g.open(self.uri, create=True)
+        if rt == NO_STORE:
+            g.open(self.uri, create=True)
+        else:
+            assert rt == VALID_STORE, "The underlying store is corrupt"
+        g.destroy(self.uri)
+
+
 SQLAMySQLGraphTestCase.storetest = True
 SQLAMySQLContextTestCase.storetest = True
+SQLAMySQLIssueTestCase.storetest = True
 
 if __name__ == '__main__':
     unittest.main()