style: Eliminate quotes from type hints (#2578)

Since `from __future__ import annotations` is now in place where type
hints are used, there is no need to use quotes in type hints.

Other changes:
- Clean up nitpick settings in Sphinx configuration.

Author: aucampia

docs/conf.py

@@ -274,63 +274,17 @@ def find_version(filename):
 
 nitpicky = True
 
-if sphinx_version < (5,):
-    # Being nitpicky on Sphinx 4.x causes lots of problems.
-    logging.warning(
-        "disabling nitpicky because sphinx is too old: %s", sphinx.__version__
-    )
-    nitpicky = False
-
 nitpick_ignore = [
     ("py:class", "urllib.response.addinfourl"),
-    ("py:data", "typing.Literal"),
-    ("py:class", "typing.IO[bytes]"),
-    ("py:class", "http.client.HTTPMessage"),
     ("py:class", "importlib.metadata.EntryPoint"),
     ("py:class", "xml.dom.minidom.Document"),
     ("py:class", "xml.dom.minidom.DocumentFragment"),
     ("py:class", "isodate.duration.Duration"),
-    # sphinx-autodoc-typehints has some issues with TypeVars.
-    # https://github.com/tox-dev/sphinx-autodoc-typehints/issues/39
-    ("py:class", "rdflib.plugin.PluginT"),
-    # sphinx-autodoc-typehints does not like generic parmaeters in inheritance it seems
-    ("py:class", "Identifier"),
-    # These are related to pyparsing.
-    ("py:class", "Diagnostics"),
-    ("py:class", "ParseAction"),
-    ("py:class", "ParseFailAction"),
     ("py:class", "pyparsing.core.TokenConverter"),
     ("py:class", "pyparsing.results.ParseResults"),
     ("py:class", "pyparsing.core.ParserElement"),
-    # These are related to BerkeleyDB
-    ("py:class", "db.DBEnv"),
 ]
 
-if sys.version_info < (3, 9):
-    nitpick_ignore.extend(
-        [
-            ("py:class", "_ContextIdentifierType"),
-            ("py:class", "_ContextType"),
-            ("py:class", "_GraphT"),
-            ("py:class", "_NamespaceSetString"),
-            ("py:class", "_ObjectType"),
-            ("py:class", "_PredicateType"),
-            ("py:class", "_QuadSelectorType"),
-            ("py:class", "_SubjectType"),
-            ("py:class", "_TripleOrPathTripleType"),
-            ("py:class", "_TripleOrQuadPathPatternType"),
-            ("py:class", "_TripleOrQuadPatternType"),
-            ("py:class", "_TriplePathPatternType"),
-            ("py:class", "_TriplePathType"),
-            ("py:class", "_TriplePatternType"),
-            ("py:class", "_TripleSelectorType"),
-            ("py:class", "_TripleType"),
-            ("py:class", "_TripleOrTriplePathType"),
-            ("py:class", "TextIO"),
-            ("py:class", "Message"),
-        ]
-    )
-
 
 def autodoc_skip_member_handler(
     app: sphinx.application.Sphinx,

pyproject.toml

@@ -89,6 +89,7 @@ select = [
     "N", # pep8-naming
     "RUF100", # Unused noqa directive
     "UP010", # Unnecessary __future__ import for target Python version
+    "UP037", # Remove quotes from type annotation
     "FA", # flake8-future-annotations
 ]
 

rdflib/compare.py

@@ -251,7 +251,7 @@ def stringify(x):
         self._hash_cache[color] = val
         return val
 
-    def distinguish(self, W: "Color", graph: Graph):  # noqa: N803
+    def distinguish(self, W: Color, graph: Graph):  # noqa: N803
         colors: Dict[str, Color] = {}
         for n in self.nodes:
             new_color: Tuple[ColorItem, ...] = list(self.color)  # type: ignore[assignment]
@@ -521,7 +521,7 @@ def canonical_triples(self, stats: Optional[Stats] = None):
 
     def _canonicalize_bnodes(
         self,
-        triple: "_TripleType",
+        triple: _TripleType,
         labels: Dict[Node, str],
     ):
         for term in triple: