Move coveralls to GitHub Actions (#1877)

This is so coverage is reported for python version and OS specific
behavior, and also adds back coveralls PR commenting so it is easier
to see changes in coverage before merging.

Author: aucampia

.drone.yml

@@ -9,29 +9,17 @@ platform:
 steps:
 - name: test
   image: python:3.7
-  environment:
-    COVERALLS_SERVICE_NAME: RDFLib-Drone
-    COVERALLS_REPO_TOKEN:
-      from_secret: coveralls_token
   commands:
-  - export COVERALLS_SERVICE_NUMBER="$DRONE_BUILD_NUMBER"
-  - export COVERALLS_SERVICE_JOB_ID="$DRONE_STAGE_NAME"
-  - export COVERALLS_SERVICE_JOB_NUMBER="$DRONE_BUILD_NUMBER"
-  - export COVERALLS_FLAG_NAME="$DRONE_STAGE_KIND"
-  - export COVERALLS_GIT_REPO="$DRONE_REPO_NAME"
-  - export COVERALLS_GIT_BRANCH="$DRONE_SOURCE_BRANCH"
   - export CI_BRANCH="$DRONE_SOURCE_BRANCH"
   - apt-get update && apt-get install -y openjdk-11-jdk-headless
   - pip install --default-timeout 60 -r requirements.txt
   - pip install --default-timeout 60 -r requirements.dev.txt
   - pip install --default-timeout 60 -r requirements.dev-extra.txt
-  - pip install --default-timeout 60 coveralls && export HAS_COVERALLS=1
   - python setup.py install
   - black --config black.toml --check ./rdflib || true
   - flake8 --exit-zero rdflib
   - mypy --show-error-context --show-error-codes
   - ./with-fuseki.sh pytest -ra --cov
-  - coveralls
 
 ---
 kind: pipeline

.github/workflows/validate.yaml

@@ -73,11 +73,22 @@ jobs:
       - name: Run validation
         shell: bash
         run: |
-          export TOX_EXTRA_COMMAND="${{ matrix.TOX_EXTRA_COMMAND }}"
           task \
+            TOX_EXTRA_COMMAND="${{ matrix.TOX_EXTRA_COMMAND }}" \
+            OS=${{ matrix.os }} \
             EXTENSIVE=${{ matrix.extensive-tests }} \
             TOX_PYTHON_VERSION=${{ matrix.python-version }} \
-            WITH_GITHUB_ACTIONS=1 \
-            install:system-deps \
-            install:tox \
-            tox
+            gha:validate
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  finish:
+    permissions:
+      contents: read
+    needs: validate
+    runs-on: ubuntu-latest
+    steps:
+      - name: Coveralls Finished
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          parallel-finished: true

README.md

@@ -2,7 +2,7 @@
 
 RDFLib
 ======
-[![Build Status](https://drone.rdflib.ashs.dev/api/badges/RDFLib/rdflib/status.svg?ref=refs/heads/master)](https://drone.rdflib.ashs.dev/RDFLib/rdflib/branches)
+[![Build Status](https://github.com/RDFLib/rdflib/actions/workflows/validate.yaml/badge.svg?branch=master)](https://github.com/RDFLib/rdflib/actions?query=branch%3Amaster)
 [![Coveralls branch](https://img.shields.io/coveralls/RDFLib/rdflib/master.svg)](https://coveralls.io/r/RDFLib/rdflib?branch=master)
 [![GitHub stars](https://img.shields.io/github/stars/RDFLib/rdflib.svg)](https://github.com/RDFLib/rdflib/stargazers)
 [![PyPI](https://img.shields.io/pypi/v/rdflib.svg)](https://pypi.python.org/pypi/rdflib)

Taskfile.yml

@@ -50,7 +50,7 @@ tasks:
   install:tox:
     desc: Install tox
     cmds:
-    - "{{._PYTHON}} -m pip install tox {{if .WITH_GITHUB_ACTIONS}}tox-gh-actions{{end}}"
+      - "{{._PYTHON}} -m pip install tox {{if .WITH_GITHUB_ACTIONS}}tox-gh-actions{{end}}"
 
   install:pip-deps:
     desc: Install pip dependencies
@@ -74,17 +74,23 @@ tasks:
   venv:clean:
     desc: Remove the venv at VENV_PATH(={{.VENV_PATH}})
     cmds:
-    - task: _rimraf
-      vars: { _PYTHON: "{{.PYTHON}}", RIMRAF_TARGET: "{{.VENV_PATH}}" }
+      - task: _rimraf
+        vars: { _PYTHON: "{{.PYTHON}}", RIMRAF_TARGET: "{{.VENV_PATH}}" }
 
   tox:
     desc: Run tox
     cmds:
       - echo "TOXENV=${TOXENV}"
-      - "{{.TEST_HARNESS}}{{._PYTHON}} -m tox {{.CLI_ARGS}}"
+      - |
+        {{if .TOX_PYTEST_ARGS}}TOX_PYTEST_ARGS={{shellQuote .TOX_PYTEST_ARGS}}{{end}} \
+        {{if .TOX_EXTRA_COMMAND}}TOX_EXTRA_COMMAND={{shellQuote .TOX_EXTRA_COMMAND}}{{end}} \
+        {{if .COVERAGE_FILE}}COVERAGE_FILE={{shellQuote .COVERAGE_FILE}}{{end}} \
+        {{.TEST_HARNESS}} \
+        {{._PYTHON}} \
+          -m tox \
+          {{.CLI_ARGS}}
     env:
       TOXENV: '{{if .TOX_PYTHON_VERSION}}py{{replace "." "" .TOX_PYTHON_VERSION}}{{if .EXTENSIVE}}-extensive{{end}}{{end}}'
-
   test:
     desc: Run tests
     cmds:
@@ -145,21 +151,21 @@ tasks:
   clean:mypy:
     desc: Clean mypy cache
     cmds:
-    - task: _rimraf
-      vars: { RIMRAF_TARGET: ".mypy_cache" }
-    - task: clean:tox:mypy
+      - task: _rimraf
+        vars: { RIMRAF_TARGET: ".mypy_cache" }
+      - task: clean:tox:mypy
 
   clean:tox:
     desc: Clean tox environments
     cmds:
-    - task: _rimraf
-      vars: { RIMRAF_TARGET: ".tox" }
+      - task: _rimraf
+        vars: { RIMRAF_TARGET: ".tox" }
 
   clean:tox:mypy:
     desc: Clean mypy cache inside tox environments
     cmds:
-    - task: _rimraf
-      vars: { RIMRAF_TARGET: ".tox/*/.mypy_cache/" }
+      - task: _rimraf
+        vars: { RIMRAF_TARGET: ".tox/*/.mypy_cache/" }
 
   clean:
     desc: Clean everything
@@ -189,6 +195,23 @@ tasks:
     cmds:
       - pre-commit run --all-files  {{.CLI_ARGS}}
 
+  gha:validate:
+    desc: GitHub Actions Validation Workflow
+    env:
+      COVERALLS_PARALLEL: true
+      COVERALLS_FLAG_NAME: "{{.OS}}-{{.TOX_PYTHON_VERSION}}"
+      COVERALLS_SERVICE_NAME: '{{.COVERALLS_SERVICE_NAME | default (env "COVERALLS_SERVICE_NAME") | default "github"}}'
+    cmds:
+      - task: install:system-deps
+      - task: install:tox
+        vars:
+          WITH_GITHUB_ACTIONS: 1
+      - cmd: "{{._PYTHON}} -m pip install coveralls"
+      - task: tox
+        vars:
+          COVERAGE_FILE: ".coverage"
+      - cmd: coveralls
+
   _rimraf:
     # This task is a utility task for recursively removing directories, it is
     # similar to rm -rf but not identical and it should work wherever there is

tox.ini

@@ -5,8 +5,8 @@ envlist =
 [testenv]
 setenv =
     extensive: BERKELEYDB_DIR = /usr
-    COVERAGE_FILE={toxinidir}/.coverage.{envname}
-    MYPY_CACHE_DIR={envdir}/.mypy_cache
+    COVERAGE_FILE = {env:COVERAGE_FILE:{toxinidir}/.coverage.{envname}}
+    MYPY_CACHE_DIR = {envdir}/.mypy_cache
 extras =
     tests
     dev
@@ -15,7 +15,7 @@ extras =
 commands =
     {env:TOX_EXTRA_COMMAND:}
     {env:TOX_MYPY_COMMAND:{envpython} -m mypy --show-error-context --show-error-codes}
-    {posargs:{envpython} -m pytest --cov --cov-report=}
+    {posargs:{envpython} -m pytest {env:TOX_PYTEST_ARGS:--cov --cov-report=}}
 
 [testenv:covreport]
 deps = coverage