Added Exception for URI too long (414). Related to #124

Author: dayures

SPARQLWrapper/SPARQLExceptions.py

@@ -28,31 +28,40 @@ def __init__(self, response=None):
 
 class EndPointInternalError(SPARQLWrapperException):
     """
-    Exception type for 500 Internal Server Error responses.
+    Exception type for 500 Internal Server Error responses. Usually HTTP response status code 500.
     """
 
     msg = "endpoint returned code 500 and response"
 
 
 class QueryBadFormed(SPARQLWrapperException):
     """
-    Query Bad Formed exception
+    Query Bad Formed exception. Usually HTTP response status code 400.
     """
 
     msg = "a bad request has been sent to the endpoint, probably the sparql query is bad formed"
 
 
 class EndPointNotFound(SPARQLWrapperException):
     """
-    End Point Not Found exception
+    End Point Not Found exception. Usually HTTP response status code 404.
     """
 
     msg = "it was impossible to connect with the endpoint in that address, check if it is correct"
 
 class Unauthorized(SPARQLWrapperException):
     """
-    Access is denied due to invalid credentials (unauthorized).
+    Access is denied due to invalid credentials (unauthorized). Usually HTTP response status code 401.
     @since: 1.8.2
     """
 
     msg = "access is denied due to invalid credentials (unauthorized). Check the credentials"
+
+class URITooLong(SPARQLWrapperException):
+    """
+    The URI requested by the client is longer than the server is willing to interpret. Usually HTTP response status code 414.
+    @since: 1.8.3
+    """
+
+    msg = "the URI requested by the client is longer than the server is willing to interpret. Check if the request was sent using GET method instead of POST method."
+

SPARQLWrapper/Wrapper.py

@@ -51,7 +51,7 @@
 
 import json
 from KeyCaseInsensitiveDict import KeyCaseInsensitiveDict
-from SPARQLExceptions import QueryBadFormed, EndPointNotFound, EndPointInternalError, Unauthorized
+from SPARQLExceptions import QueryBadFormed, EndPointNotFound, EndPointInternalError, Unauthorized, URITooLong
 from SPARQLWrapper import __agent__
 
 #  From <https://www.w3.org/TR/sparql11-protocol/#query-success>
@@ -868,6 +868,7 @@ def _query(self):
         @raise QueryBadFormed: If the C{HTTP return code} is C{400}.
         @raise Unauthorized: If the C{HTTP return code} is C{401}.
         @raise EndPointNotFound: If the C{HTTP return code} is C{404}.
+        @raise URITooLong: If the C{HTTP return code} is C{414}.
         @raise EndPointInternalError: If the C{HTTP return code} is C{500}.
         """
         request = self._createRequest()
@@ -885,6 +886,8 @@ def _query(self):
                 raise EndPointNotFound(e.read())
             elif e.code == 401:
                 raise Unauthorized(e.read())
+            elif e.code == 414:
+                raise URITooLong(e.read())
             elif e.code == 500:
                 raise EndPointInternalError(e.read())
             else:

test/wrapper_test.py

@@ -37,7 +37,7 @@
 from SPARQLWrapper import XML, GET, POST, JSON, JSONLD, N3, TURTLE, RDF, SELECT, INSERT, RDFXML, CSV, TSV
 from SPARQLWrapper import URLENCODED, POSTDIRECTLY
 from SPARQLWrapper import BASIC, DIGEST
-from SPARQLWrapper.Wrapper import QueryResult, QueryBadFormed, EndPointNotFound, EndPointInternalError
+from SPARQLWrapper.Wrapper import QueryResult, QueryBadFormed, EndPointNotFound, EndPointInternalError, Unauthorized, URITooLong
 
 
 class FakeResult(object):
@@ -498,6 +498,16 @@ def testQuery(self):
         except:
             self.fail('got wrong exception')
 
+        _victim.urlopener = urlopener_error_generator(401)
+        try:
+            self.wrapper.query()
+            self.fail('should have raised exception')
+        except Unauthorized as e:
+            #  TODO: check exception-format
+            pass
+        except:
+            self.fail('got wrong exception')
+
         _victim.urlopener = urlopener_error_generator(404)
         try:
             self.wrapper.query()
@@ -508,6 +518,16 @@ def testQuery(self):
         except:
             self.fail('got wrong exception')
 
+        _victim.urlopener = urlopener_error_generator(414)
+        try:
+            self.wrapper.query()
+            self.fail('should have raised exception')
+        except URITooLong as e:
+            #  TODO: check exception-format
+            pass
+        except:
+            self.fail('got wrong exception')
+
         _victim.urlopener = urlopener_error_generator(500)
         try:
             self.wrapper.query()