Skip to content

Raising ValueError if unsupported return types are requested for SELECT queries #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgupta04 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Raising ValueError if unsupported return types are requested for SELECT queries #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ff77f
Raising ValueError if unsupported return types are requested for SELE…
dgupta04 May 10, 2022
51b2c15
Added new tests and modified earlier approach
dgupta04 May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions SPARQLWrapper/Wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,11 @@ def query(self) -> "QueryResult":
:return: query result
:rtype: :class:`QueryResult` instance
"""

# Solving issue-190
unsupportedReturnTypesForSelectQueries = [RDF, RDFXML, XML]
if self.queryType == SELECT and self.returnFormat in [RDF, RDFXML, XML]:
raise ValueError(self.returnFormat.upper() + " is not a valid return format for SELECT queries. Supported formats include: %s" % ", ".join([i for i in _allowedFormats if i not in unsupportedReturnTypesForSelectQueries]))
return QueryResult(self._query())

def queryAndConvert(self) -> "QueryResult.ConvertResult":
Expand Down