refactor: use helper for recently shipping list

Author: rz1989s

app/helpers/application_helper.rb

@@ -1,2 +1,16 @@
 module ApplicationHelper
+  # Format a list of repos as "repo1, repo2 and repo3" with links
+  def recently_shipping_list(repos)
+    links = repos.map do |repo|
+      content_tag(:strong) { link_to(repo.name, repo.html_url, target: "_blank", rel: "noopener") }
+    end
+
+    if links.size == 1
+      links.first
+    elsif links.size == 2
+      safe_join(links, " and ")
+    else
+      safe_join([safe_join(links[0...-1], ", "), links.last], " and ")
+    end
+  end
 end

app/views/pages/home.html.erb

@@ -20,10 +20,8 @@
 
     <% if @recently_active_repos.any? %>
       <p class="intro-tagline mt-2">
-        Recently shipping <%= @recently_active_repos.each_with_index.map { |repo, i|
-          separator = i == 0 ? "" : (i == @recently_active_repos.size - 1 ? " and " : ", ")
-          "#{separator}<strong>#{link_to repo.name, repo.html_url, target: "_blank", rel: "noopener"}</strong>"
-        }.join.html_safe %> (latest: <%= @recently_active_repos.first.detailed_time_ago %>).
+        Recently shipping <%= recently_shipping_list(@recently_active_repos) %>
+        (latest: <%= @recently_active_repos.first.detailed_time_ago %>).
       </p>
     <% end %>
   </div>