Add TODO

NoahAndrews · NoahAndrews · commit 409d244f29b3 · 2024-03-26T13:33:33.000-05:00
diff --git a/src/canWrapper.cc b/src/canWrapper.cc
@@ -627,6 +627,7 @@ void waitForNotifierAlarm(const Napi::CallbackInfo& info) {
     int32_t status;
 
     HAL_UpdateNotifierAlarm(m_notifier, HAL_GetFPGATime(&status) + time, &status);
+    // TODO(Noah): Don't discard the returned value (this function is marked as [nodiscard])
     HAL_WaitForNotifierAlarm(m_notifier, &status);
     cb.Call(info.Env().Global(), {info.Env().Null(), Napi::Number::New(info.Env(), status)});
 }

Original file line number	Diff line number	Diff line change
`@@ -627,6 +627,7 @@ void waitForNotifierAlarm(const Napi::CallbackInfo& info) {`
`627`	`627`	`int32_t status;`
`628`	`628`
`629`	`629`	`HAL_UpdateNotifierAlarm(m_notifier, HAL_GetFPGATime(&status) + time, &status);`
	`630`	`+ // TODO(Noah): Don't discard the returned value (this function is marked as [nodiscard])`
`630`	`631`	`HAL_WaitForNotifierAlarm(m_notifier, &status);`
`631`	`632`	`cb.Call(info.Env().Global(), {info.Env().Null(), Napi::Number::New(info.Env(), status)});`
`632`	`633`	`}`