Skip to content

Commit 5712827

Browse files
Fix exceptions on macOS
EXCEPTIONS GO BRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR it's 3am and i need sleep i spent way too long on this stupid bug but thats how code goes anyways good night
1 parent 79ab7e6 commit 5712827

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

binding.gyp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@
7373
},
7474
"xcode_settings": {
7575
"CLANG_CXX_LANGUAGE_STANDARD": "c++20",
76-
"OTHER_CPLUSPLUSFLAGS": ["-fexceptions"]
76+
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
77+
'GCC_ENABLE_CPP_RTTI': 'YES',
78+
"OTHER_CPLUSPLUSFLAGS": ["-fexceptions"],
79+
# 'MACOSX_DEPLOYMENT_TARGET': '14.0',
7780
},
7881
"cflags_cc": ["-std=c++20", '-fexceptions'],
7982
"cflags": ["-std=c++20", '-fexceptions'],

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@rev-robotics/can-bridge",
3-
"version": "3.2.0",
3+
"version": "3.2.6",
44
"author": "REV Robotics",
55
"description": "Access CAN Data from a USB device in Node.js",
66
"license": "MIT",

scripts/download-CanBridge.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import axios from 'axios';
44
import AdmZip from 'adm-zip';
55
import { platform, arch } from 'os';
66

7-
const canBridgeTag = "v2.3.3";
7+
const canBridgeTag = "v2.3.6";
88
const canBridgeReleaseAssetUrlPrefix = `https://github.com/unofficial-rev-port/CANBridge/releases/download/${canBridgeTag}`;
99

1010
const externalCompileTimeDepsPath = 'externalCompileTimeDeps';

0 commit comments

Comments
 (0)