Release 2.8.5 (#1599)

* --slave to --no-echo

* Update CHANGLOG.md

Author: randy3k

CHANGELOG.md

@@ -4,6 +4,11 @@
 
 You can check all of our changes from [Release Page](https://github.com/REditorSupport/vscode-R/releases)
 
+## [2.8.5](https://github.com/REditorSupport/vscode-R/releases/tag/v2.8.5)
+
+* Upgrade Rsyntax
+* Use --no-echo instead of --slave
+
 ## [2.8.4](https://github.com/REditorSupport/vscode-R/releases/tag/v2.8.4)
 
 * Upgrade dependencies

CODE_OF_CONDUCT.md

@@ -34,7 +34,7 @@ This Code of Conduct applies both within project spaces and in public spaces whe
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at <[email protected]>. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
 
 Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
 

src/helpViewer/helpPreviewer.ts

@@ -239,7 +239,7 @@ export class RLocalHelpPreviewer {
         // Convert .Rd to HTML
         const args = [
             '--silent',
-            '--slave',
+            '--no-echo',
             '--no-save',
             '--no-restore',
             '-f',

src/helpViewer/helpProvider.ts

@@ -49,7 +49,7 @@ export class HelpProvider {
         const scriptPath = extensionContext.asAbsolutePath('R/help/helpServer.R');
         const args = [
             '--silent',
-            '--slave',
+            '--no-echo',
             '--no-save',
             '--no-restore',
             '-e',
@@ -259,7 +259,7 @@ export class AliasProvider {
 
         const args = [
             '--silent',
-            '--slave',
+            '--no-echo',
             '--no-save',
             '--no-restore',
             '-f',

src/helpViewer/packages.ts

@@ -193,7 +193,7 @@ export class PackageManager {
     // remove a specified package. The packagename is selected e.g. in the help tree-view
     public async removePackage(pkgName: string): Promise<boolean> {
         const rPath = this.rHelp.rPath;
-        const args = ['--silent', '--slave', '--no-save', '--no-restore', '-e', `remove.packages('${pkgName}')`];
+        const args = ['--silent', '--no-echo', '--no-save', '--no-restore', '-e', `remove.packages('${pkgName}')`];
         const cmd = `${rPath} ${args.join(' ')}`;
         const confirmation = 'Yes, remove package!';
         const prompt = `Are you sure you want to remove package ${pkgName}?`;
@@ -211,7 +211,7 @@ export class PackageManager {
     public async installPackages(pkgNames: string[], skipConfirmation: boolean = false): Promise<boolean> {
         const rPath = this.rHelp.rPath;
         const cranUrl = await getCranUrl('', this.cwd);
-        const args = [`--silent`, '--slave', `-e`, `install.packages(c(${pkgNames.map(v => `'${v}'`).join(',')}),repos='${cranUrl}')`];
+        const args = [`--silent`, '--no-echo', `-e`, `install.packages(c(${pkgNames.map(v => `'${v}'`).join(',')}),repos='${cranUrl}')`];
         const cmd = `${rPath} ${args.join(' ')}`;
         const pluralS = pkgNames.length > 1? 's' : '';
         const confirmation = `Yes, install package${pluralS}!`;
@@ -227,7 +227,7 @@ export class PackageManager {
     public async updatePackages(skipConfirmation: boolean = false): Promise<boolean> {
         const rPath = this.rHelp.rPath;
         const cranUrl = await getCranUrl('', this.cwd);
-        const args = ['--silent', '--slave', '--no-save', '--no-restore', '-e', `update.packages(ask=FALSE,repos='${cranUrl}')`];
+        const args = ['--silent', '--no-echo', '--no-save', '--no-restore', '-e', `update.packages(ask=FALSE,repos='${cranUrl}')`];
         const cmd = `${rPath} ${args.join(' ')}`;
         const confirmation = 'Yes, update all packages!';
         const prompt = 'Are you sure you want to update all installed packages? This might take some time!';

src/languageService.ts

@@ -86,7 +86,7 @@ export class LanguageService implements Disposable {
         const options = { cwd: cwd, env: env };
         const args = (config.get<string[]>('lsp.args')?.map(substituteVariables) ?? []).concat(
             '--silent',
-            '--slave',
+            '--no-echo',
             '--no-save',
             '--no-restore',
             '-e',

src/rmarkdown/draft.ts

@@ -35,7 +35,7 @@ async function getTemplateItems(cwd: string): Promise<TemplateItem[] | undefined
     const rScriptFile = extensionContext.asAbsolutePath('R/rmarkdown/templates.R');
     const args = [
         '--silent',
-        '--slave',
+        '--no-echo',
         '--no-save',
         '--no-restore',
         '-f',

src/rmarkdown/manager.ts

@@ -65,10 +65,10 @@ export abstract class RMarkdownManager {
                 const scriptArgs = args.scriptArgs;
                 const scriptPath = args.scriptPath;
                 const fileName = args.fileName;
-                // const cmd = `${this.rPath} --silent --slave --no-save --no-restore -f "${scriptPath}"`;
+                // const cmd = `${this.rPath} --silent --no-echo --no-save --no-restore -f "${scriptPath}"`;
                 const cpArgs = [
                     '--silent',
-                    '--slave',
+                    '--no-echo',
                     '--no-save',
                     '--no-restore',
                     '-f',

src/util.ts

@@ -352,7 +352,7 @@ export async function executeRCommand(rCommand: string, cwd?: string | URL, fall
     const lim = '---vsc---';
     const args = [
         '--silent',
-        '--slave',
+        '--no-echo',
         '--no-save',
         '--no-restore',
         '-e', `cat('${lim}')`,
@@ -555,7 +555,7 @@ export async function promptToInstallRPackage(name: string, section: string, cwd
                     void vscode.window.showErrorMessage('R path not set', 'OK');
                     return;
                 }
-                const args = ['--silent', '--slave', '--no-save', '--no-restore', '-e', `install.packages('${name}', repos='${repo}')`];
+                const args = ['--silent', '--no-echo', '--no-save', '--no-restore', '-e', `install.packages('${name}', repos='${repo}')`];
                 void executeAsTask('Install Package', rPath, args, true);
                 if (postInstallMsg) {
                     void vscode.window.showInformationMessage(postInstallMsg, 'OK');