Race condition in payment test

[Arshia-r-m]

I just faced this race condition https://github.com/RGB-Tools/rgb-lightning-node/actions/runs/22769268314/job/66045414332#step:4:1293 , where the payment must be in pending but it succeeds so fast causing the race condition, Is there any specific reason to check if the HTLC status is pending?

[zoedberg]

Thanks for reporting this.

I think the check was there to make sure the status of the payment right after the call to the API is pending and not already settled. We could remove the check but the best would be to add a synchronization mechanism (lock/semaphore) in the event handler triggered only during the tests to prevent these race conditions.

[Arshia-r-m]

I'll try to work on this and open a PR for it!