Skip to content

Commit 0a8b9d0

Browse files
authored
Merge pull request #21668 from benpicco/makefiles/CI-RIOT_VERSION_CODE
build-system: don't set `RIOT_VERSION_CODE` to dummy value in CI
2 parents a23e100 + 6aa434e commit 0a8b9d0

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Makefile.include

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -514,8 +514,6 @@ export CCACHE_CPP2=yes
514514
# set some settings useful for continuous integration builds
515515
ifeq ($(RIOT_CI_BUILD),1)
516516
RIOT_VERSION ?= buildtest
517-
# set a dummy version number
518-
RIOT_VERSION_CODE ?= $(RIOT_VERSION_DUMMY_CODE)
519517
ifneq ($(filter $(BOARD_INSUFFICIENT_MEMORY), $(BOARD)),)
520518
RIOTNOLINK:=1
521519
endif
@@ -560,7 +558,8 @@ include $(RIOTMAKE)/cflags.inc.mk
560558
-include $(RIOTBASE)/EXTRAVERSION
561559

562560
include $(RIOTMAKE)/git_version.inc.mk
563-
RIOT_VERSION ?= $(or $(GIT_VERSION),'UNKNOWN (builddir: $(RIOTBASE))')
561+
RIOT_VERSION_GIT := $(or $(GIT_VERSION),'UNKNOWN (builddir: $(RIOTBASE))')
562+
RIOT_VERSION ?= $(RIOT_VERSION_GIT)
564563
RIOT_EXTRAVERSION ?= 0
565564

566565
# Deprecate using RIOT_VERSION_OVERRIDE but currently keep the behavior
@@ -570,7 +569,7 @@ ifneq (,$(RIOT_VERSION_OVERRIDE))
570569
endif
571570

572571
# Generate machine readable RIOT VERSION macro
573-
RIOT_VERSION_CODE ?= $(shell echo $(RIOT_VERSION) | \
572+
RIOT_VERSION_CODE ?= $(shell echo $(RIOT_VERSION_GIT) | \
574573
sed -E 's/([0-9]+)\.([0-9]+)\.?([0-9]+)?.*/RIOT_VERSION_NUM\\\(\1,\2,0\3,$(RIOT_EXTRAVERSION)\\\)/' | \
575574
grep RIOT_VERSION_NUM || echo "$(RIOT_VERSION_DUMMY_CODE)")
576575

0 commit comments

Comments
 (0)