Merge pull request #21833 from mguetschow/lwip-netdev-type-fix

pkg/lwip/netdev: fix return types in send()

Author: crasbe

pkg/lwip/contrib/netdev/Makefile

@@ -1,3 +1,5 @@
 MODULE := lwip_netdev
 
+USEMODULE += tiny_strerror
+
 include $(RIOTBASE)/Makefile.base

pkg/lwip/contrib/netdev/lwip_netdev.c

@@ -37,6 +37,7 @@
 #include "netif/lowpan6.h"
 #include "thread.h"
 #include "thread_flags.h"
+#include "tiny_strerror.h"
 #include "utlist.h"
 
 #define ENABLE_DEBUG                0
@@ -275,11 +276,11 @@ static err_t _common_link_output(struct netif *netif, netdev_t *netdev, iolist_t
 {
     lwip_netif_dev_acquire(netif);
 
-    err_t res;
+    int res;
     if (is_netdev_legacy_api(netdev)) {
-        res = (netdev->driver->send(netdev, iolist) > 0) ? ERR_OK : ERR_BUF;
+        res = netdev->driver->send(netdev, iolist);
         lwip_netif_dev_release(netif);
-        return res;
+        return res > 0 ? ERR_OK : ERR_BUF;
     }
 
     unsigned irq_state;
@@ -295,6 +296,7 @@ static err_t _common_link_output(struct netif *netif, netdev_t *netdev, iolist_t
         irq_state = irq_disable();
         compat_netif->thread_doing_tx = NULL;
         irq_restore(irq_state);
+        DEBUG("[lwip_netdev] send() returned %s\n", tiny_strerror(res));
         return ERR_IF;
     }
 
@@ -320,6 +322,7 @@ static err_t _common_link_output(struct netif *netif, netdev_t *netdev, iolist_t
     lwip_netif_dev_release(netif);
 
     if (res < 0) {
+        DEBUG("[lwip_netdev] confirm_send() returned %s\n", tiny_strerror(res));
         return ERR_IF;
     }
 
@@ -329,9 +332,9 @@ static err_t _common_link_output(struct netif *netif, netdev_t *netdev, iolist_t
 static err_t _common_link_output(struct netif *netif, netdev_t *netdev, iolist_t *iolist)
 {
     lwip_netif_dev_acquire(netif);
-    err_t res = (netdev->driver->send(netdev, iolist) > 0) ? ERR_OK : ERR_BUF;
+    int res = netdev->driver->send(netdev, iolist);
     lwip_netif_dev_release(netif);
-    return res;
+    return res > 0 ? ERR_OK : ERR_BUF;
 }
 #endif