Merge pull request #21695 from benpicco/suit_fetch-info

crasbe · web-flow · commit 8774ed26d1c2 · 2025-09-05T06:47:12.000Z
sys/suit: print firmware URL if download fails
diff --git a/sys/suit/handlers_command_seq.c b/sys/suit/handlers_command_seq.c
@@ -475,7 +475,7 @@ static int _dtv_fetch(suit_manifest_t *manifest, int key,
         suit_component_set_flag(comp, SUIT_COMPONENT_STATE_FETCH_FAILED);
         /* TODO: The leftover data from a failed fetch should be purged. It
          * could contain potential malicious data from an attacker */
-        LOG_INFO("image download failed with code %i\n", res);
+        LOG_INFO("image download (%s) failed with code %i\n", manifest->urlbuf, res);
         return res;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ static int _dtv_fetch(suit_manifest_t *manifest, int key,`
`475`	`475`	`suit_component_set_flag(comp, SUIT_COMPONENT_STATE_FETCH_FAILED);`
`476`	`476`	`/* TODO: The leftover data from a failed fetch should be purged. It`
`477`	`477`	`* could contain potential malicious data from an attacker */`
`478`		`- LOG_INFO("image download failed with code %i\n", res);`
	`478`	`+ LOG_INFO("image download (%s) failed with code %i\n", manifest->urlbuf, res);`
`479`	`479`	`return res;`
`480`	`480`	`}`
`481`	`481`