File tree Expand file tree Collapse file tree 1 file changed +8
-1
lines changed Expand file tree Collapse file tree 1 file changed +8
-1
lines changed Original file line number Diff line number Diff line change @@ -149,6 +149,10 @@ It is possible to check if your code follows these conventions:
149149 simple as it is.
150150 ```
151151
152+ * The commit message is automatically checked by the static tests for keywords
153+ that prevent a merge, for example "fixup" or "DONOTMERGE". The full list
154+ of these keywords is stored in ` dist/tools/pr_check/no_merge_keywords ` .
155+
152156### Pull Requests
153157[ pull requests ] : #pull-requests
154158
@@ -304,6 +308,9 @@ $ git commit --fixup <prefix2 commit hash>
304308
305309### Squash commits after review
306310
311+ ** * Note: If the static tests warn you about a no-merge keyword, please look
312+ at [ our commit conventions] [ commit-conventions ] .
313+
307314Squashing a commit is done using the rebase subcommand of git in interactive
308315mode:
309316
@@ -323,7 +330,7 @@ phase, squashing commits can be performed in a single command:
323330$ git rebase -i --autosquash
324331```
325332
326- ** Watch out: Don't squash your commit until a maintainer asks you to do it.**
333+ *** Watch out: Don't squash your commit until a maintainer asks you to do it.* **
327334
328335Otherwise the history of review changes is lost and for large PRs, it
329336makes it difficult for the reviewer to follow them. It might also happen that
You can’t perform that action at this time.
0 commit comments