makefiles: hide security warnings for info targets

Security warnings (telnet, stdio_udp, psa_crypto) were displayed even
for info-* targets, polluting the output and breaking tools that parse
make output (e.g., compile_and_test_for_board.py).

These warnings are only relevant when actually building/running code,
not when querying build system information.

Signed-off-by: Gilles DOFFE <[email protected]>

Author: gdoffe

makefiles/dependency_resolution.inc.mk

@@ -94,37 +94,40 @@ else
     $(error "The following non-existing features are listed in FEATURES_OPTIONAL: $(FEATURES_NONEXISTING)")
   endif
 
-  # Warn about telnet
-  ifneq (,$(filter auto_init_telnet,$(USEMODULE)))
-    ifneq (1,$(I_UNDERSTAND_THAT_TELNET_IS_INSECURE))
-      $(shell $(COLOR_ECHO) "$(COLOR_RED)Telnet will be started automatically, "\
-                            "make sure you understand why this almost certainly "\
-                            "is a REALLY BAD idea before proceeding!$(COLOR_RESET)" 1>&2)
-      $(error I_UNDERSTAND_THAT_TELNET_IS_INSECURE must be set to 1 to proceed)
-    else
-      $(shell $(COLOR_ECHO) "$(COLOR_YELLOW)Telnet will be started automatically,"\
-                            "don't run this on public networks!$(COLOR_RESET)" 1>&2)
+  # Don't show warnings for info targets
+  ifeq (,$(filter info-%,$(MAKECMDGOALS)))
+    # Warn about telnet
+    ifneq (,$(filter auto_init_telnet,$(USEMODULE)))
+      ifneq (1,$(I_UNDERSTAND_THAT_TELNET_IS_INSECURE))
+        $(shell $(COLOR_ECHO) "$(COLOR_RED)Telnet will be started automatically, "\
+                              "make sure you understand why this almost certainly "\
+                              "is a REALLY BAD idea before proceeding!$(COLOR_RESET)" 1>&2)
+        $(error I_UNDERSTAND_THAT_TELNET_IS_INSECURE must be set to 1 to proceed)
+      else
+        $(shell $(COLOR_ECHO) "$(COLOR_YELLOW)Telnet will be started automatically,"\
+                              "don't run this on public networks!$(COLOR_RESET)" 1>&2)
+      endif
     endif
-  endif
 
-  # Warn about STDIO UDP
-  ifneq (,$(filter stdio_udp,$(USEMODULE)))
-    ifneq (1,$(I_UNDERSTAND_THAT_STDIO_UDP_IS_INSECURE))
-      $(shell $(COLOR_ECHO) "$(COLOR_RED)stdio via UDP will be started automatically,"\
-                            "make sure you understand why this almost certainly"\
-                            "is a REALLY BAD idea before proceeding!$(COLOR_RESET)" 1>&2)
-      $(error I_UNDERSTAND_THAT_STDIO_UDP_IS_INSECURE must be set to 1 to proceed)
-    else
-      $(shell $(COLOR_ECHO) "$(COLOR_YELLOW)stdio via UDP will be started automatically,"\
-                            "don't run this on public networks!$(COLOR_RESET)" 1>&2)
+    # Warn about STDIO UDP
+    ifneq (,$(filter stdio_udp,$(USEMODULE)))
+      ifneq (1,$(I_UNDERSTAND_THAT_STDIO_UDP_IS_INSECURE))
+        $(shell $(COLOR_ECHO) "$(COLOR_RED)stdio via UDP will be started automatically,"\
+                              "make sure you understand why this almost certainly"\
+                              "is a REALLY BAD idea before proceeding!$(COLOR_RESET)" 1>&2)
+        $(error I_UNDERSTAND_THAT_STDIO_UDP_IS_INSECURE must be set to 1 to proceed)
+      else
+        $(shell $(COLOR_ECHO) "$(COLOR_YELLOW)stdio via UDP will be started automatically,"\
+                              "don't run this on public networks!$(COLOR_RESET)" 1>&2)
+      endif
     endif
-  endif
 
-  # Warn about PSA Crypto
-  ifneq (,$(filter psa_crypto,$(USEMODULE)))
-    $(shell $(COLOR_ECHO) "$(COLOR_YELLOW) You are going to use the PSA Crypto module,"\
-                          "which is only partly implemented and not yet thouroughly tested.\n"\
-                          "Please do not use this module in production, as it may introduce"\
-                          "security issues!$(COLOR_RESET)" 1>&2)
+    # Warn about PSA Crypto
+    ifneq (,$(filter psa_crypto,$(USEMODULE)))
+      $(shell $(COLOR_ECHO) "$(COLOR_YELLOW) You are going to use the PSA Crypto module,"\
+                            "which is only partly implemented and not yet thouroughly tested.\n"\
+                            "Please do not use this module in production, as it may introduce"\
+                            "security issues!$(COLOR_RESET)" 1>&2)
+    endif
   endif
 endif