Skip to content

Commit 2dfd57e

Browse files
committed
refactor: improve error logging in Dynamixel hardware interface
1 parent e2bb092 commit 2dfd57e

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/dynamixel/dynamixel.cpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,7 +1325,7 @@ DxlError Dynamixel::SetDxlValueToSyncWrite()
13251325
}
13261326

13271327
if (group_sync_write_->addParam(ID, param_write_value) != true) {
1328-
printf("[ID:%03d] groupSyncWrite addparam failed\n", ID);
1328+
fprintf(stderr, "[ID:%03d] groupSyncWrite addparam failed\n", ID);
13291329
return DxlError::SYNC_WRITE_FAIL;
13301330
}
13311331
}
@@ -1334,7 +1334,7 @@ DxlError Dynamixel::SetDxlValueToSyncWrite()
13341334
group_sync_write_->clearParam();
13351335

13361336
if (dxl_comm_result != COMM_SUCCESS) {
1337-
printf("%s\n", packet_handler_->getTxRxResult(dxl_comm_result));
1337+
fprintf(stderr, "%s\n", packet_handler_->getTxRxResult(dxl_comm_result));
13381338
return DxlError::SYNC_WRITE_FAIL;
13391339
} else {
13401340
return DxlError::OK;
@@ -1500,10 +1500,6 @@ DxlError Dynamixel::SetDxlValueToBulkWrite()
15001500
param_write_value[added_byte + 1] = DXL_HIBYTE(value);
15011501
} else if (size == 1) {
15021502
param_write_value[added_byte] = static_cast<uint8_t>(data);
1503-
printf("[ID:%03d] Add Direct Write Item : [%s][%d][%d]\n", ID,
1504-
direct_info_write_[ID].item_name.at(item_index).c_str(),
1505-
direct_info_write_[ID].indirect_data_addr,
1506-
size);
15071503
}
15081504
added_byte += size;
15091505
}
@@ -1514,7 +1510,7 @@ DxlError Dynamixel::SetDxlValueToBulkWrite()
15141510
direct_info_write_[ID].size,
15151511
param_write_value) != true)
15161512
{
1517-
printf("[ID:%03d] groupBulkWrite addparam failed\n", ID);
1513+
fprintf(stderr, "[ID:%03d] groupBulkWrite addparam failed\n", ID);
15181514
return DxlError::BULK_WRITE_FAIL;
15191515
}
15201516
} else {
@@ -1549,7 +1545,7 @@ DxlError Dynamixel::SetDxlValueToBulkWrite()
15491545
indirect_info_write_[ID].size,
15501546
param_write_value) != true)
15511547
{
1552-
printf("[ID:%03d] groupBulkWrite addparam failed\n", ID);
1548+
fprintf(stderr, "[ID:%03d] groupBulkWrite addparam failed\n", ID);
15531549
return DxlError::BULK_WRITE_FAIL;
15541550
}
15551551
}
@@ -1559,7 +1555,7 @@ DxlError Dynamixel::SetDxlValueToBulkWrite()
15591555
group_bulk_write_->clearParam();
15601556

15611557
if (dxl_comm_result != COMM_SUCCESS) {
1562-
printf("%s\n", packet_handler_->getTxRxResult(dxl_comm_result));
1558+
fprintf(stderr, "%s\n", packet_handler_->getTxRxResult(dxl_comm_result));
15631559
return DxlError::BULK_WRITE_FAIL;
15641560
} else {
15651561
return DxlError::OK;

0 commit comments

Comments
 (0)