Skip to content

Commit cd74961

Browse files
committed
refactor: Remove unused firmware-specific model file checks to simplify DynamixelInfo class
1 parent 879d7b6 commit cd74961

File tree

2 files changed

+0
-19
lines changed

2 files changed

+0
-19
lines changed

include/dynamixel_hardware_interface/dynamixel/dynamixel_info.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,7 @@ class DynamixelInfo
6666
std::string SelectModelFileByFirmwareVersion(
6767
const std::string & base_model_name,
6868
uint8_t firmware_version);
69-
bool IsFirmwareSpecificModelFile(const std::string & filename);
7069
uint8_t ExtractFirmwareVersionFromFilename(const std::string & filename);
71-
bool ShouldUseFirmwareSpecificModel(
72-
uint8_t device_firmware_version,
73-
uint8_t model_firmware_version);
7470

7571
public:
7672
// Id, Control table

src/dynamixel/dynamixel_info.cpp

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -306,12 +306,6 @@ std::string DynamixelInfo::SelectModelFileByFirmwareVersion(
306306
return selected_file;
307307
}
308308

309-
bool DynamixelInfo::IsFirmwareSpecificModelFile(const std::string & filename)
310-
{
311-
std::regex fw_pattern(R"(_fw\d+\.model$)");
312-
return std::regex_search(filename, fw_pattern);
313-
}
314-
315309
uint8_t DynamixelInfo::ExtractFirmwareVersionFromFilename(const std::string & filename)
316310
{
317311
std::regex fw_pattern(R"(_fw(\d+)\.model$)");
@@ -324,15 +318,6 @@ uint8_t DynamixelInfo::ExtractFirmwareVersionFromFilename(const std::string & fi
324318
return 0; // Return 0 if no firmware version found
325319
}
326320

327-
bool DynamixelInfo::ShouldUseFirmwareSpecificModel(
328-
uint8_t device_firmware_version,
329-
uint8_t model_firmware_version)
330-
{
331-
// Use firmware-specific model if device firmware version is <= model firmware version
332-
// This ensures backward compatibility
333-
return device_firmware_version <= model_firmware_version;
334-
}
335-
336321
bool DynamixelInfo::GetDxlControlItem(
337322
uint8_t id, std::string item_name, uint16_t & addr,
338323
uint8_t & size)

0 commit comments

Comments
 (0)