Skip to content

Commit 973f1a5

Browse files
authored
Merge pull request #2364 from emankov/amd-develop
[HIPIFY][FILE][#2174][#2362][fix] Fix typo: `CUDA_DRV_ERR` -> `CU_FILE_CUDA_ERR`
2 parents dc74d20 + a14bd3c commit 973f1a5

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

bin/hipify-perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9857,12 +9857,12 @@ sub simpleSubstitutions {
98579857
subst("CUDA_ARRAY3D_TEXTURE_GATHER", "hipArrayTextureGather", "define");
98589858
subst("CUDA_COOPERATIVE_LAUNCH_MULTI_DEVICE_NO_POST_LAUNCH_SYNC", "hipCooperativeLaunchMultiDeviceNoPostSync", "define");
98599859
subst("CUDA_COOPERATIVE_LAUNCH_MULTI_DEVICE_NO_PRE_LAUNCH_SYNC", "hipCooperativeLaunchMultiDeviceNoPreSync", "define");
9860-
subst("CUDA_DRV_ERR", "HIP_DRV_ERR", "define");
98619860
subst("CUDA_EXTERNAL_MEMORY_DEDICATED", "hipExternalMemoryDedicated", "define");
98629861
subst("CUDA_IPC_HANDLE_SIZE", "HIP_IPC_HANDLE_SIZE", "define");
98639862
subst("CUFILE_ERRSTR", "HIPFILE_ERRSTR", "define");
98649863
subst("CU_DEVICE_CPU", "hipCpuDeviceId", "define");
98659864
subst("CU_DEVICE_INVALID", "hipInvalidDeviceId", "define");
9865+
subst("CU_FILE_CUDA_ERR", "HIP_DRV_ERR", "define");
98669866
subst("CU_GRAPH_KERNEL_NODE_PORT_DEFAULT", "hipGraphKernelNodePortDefault", "define");
98679867
subst("CU_GRAPH_KERNEL_NODE_PORT_LAUNCH_ORDER", "hipGraphKernelNodePortLaunchCompletion", "define");
98689868
subst("CU_GRAPH_KERNEL_NODE_PORT_PROGRAMMATIC", "hipGraphKernelNodePortProgrammatic", "define");

docs/reference/tables/cuFile_API_supported_by_HIP.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
|**CUDA**|**A**|**D**|**C**|**R**|**HIP**|**A**|**D**|**C**|**R**|**U**|**E**|
1616
|:--|:-:|:-:|:-:|:-:|:--|:-:|:-:|:-:|:-:|:-:|:-:|
17-
|`CUDA_DRV_ERR`|12.9| | | |`HIP_DRV_ERR`|7.2.0| | | | | |
1817
|`CUFILE_BATCH`|1.2.0| | | |`hipFileBatch`|7.2.0| | | | | |
1918
|`CUFILE_CANCELED`|1.2.0| | | |`hipFileCanceled`|7.2.0| | | | | |
2019
|`CUFILE_COMPLETE`|1.2.0| | | |`hipFileComplete`|7.2.0| | | | | |
@@ -64,6 +63,7 @@
6463
|`CU_FILE_BEEGFS_SUPPORTED`|1.1.1| | | |`hipFileBEEGFSSupported`|7.2.0| | | | | |
6564
|`CU_FILE_CUDA_CONTEXT_MISMATCH`|1.0.0| | | |`hipFileHipContextMismatch`|7.2.0| | | | | |
6665
|`CU_FILE_CUDA_DRIVER_ERROR`|1.0.0| | | |`hipFileHipDriverError`|7.2.0| | | | | |
66+
|`CU_FILE_CUDA_ERR`|1.0.0| | | |`HIP_DRV_ERR`|7.2.0| | | | | |
6767
|`CU_FILE_CUDA_MEMORY_TYPE_INVALID`|1.0.0| | | |`hipFileHipMemoryTypeInvalid`|7.2.0| | | | | |
6868
|`CU_FILE_CUDA_POINTER_INVALID`|1.0.0| | | |`hipFileHipPointerInvalid`|7.2.0| | | | | |
6969
|`CU_FILE_CUDA_POINTER_RANGE_ERROR`|1.0.0| | | |`hipFileHipPointerRangeError`|7.2.0| | | | | |

src/CUDA2HIP_FILE_API_types.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,7 @@ const std::map<llvm::StringRef, hipCounter> CUDA_FILE_TYPE_NAME_MAP {
146146
{"CUFILE_PARAM_LOG_DIR", {"hipFileParamLogDir", "", CONV_NUMERIC_LITERAL, API_FILE, 1}},
147147
{"IS_CUFILE_ERR", {"IS_HIPFILE_ERR", "", CONV_DEFINE, API_FILE, 1}},
148148
{"CUFILE_ERRSTR", {"HIPFILE_ERRSTR", "", CONV_DEFINE, API_FILE, 1}},
149-
// TODO: Check CUDA_DRV_ERR for existence in cuFile
150-
{"CUDA_DRV_ERR", {"HIP_DRV_ERR", "", CONV_DEFINE, API_FILE, 1}},
149+
{"CU_FILE_CUDA_ERR", {"HIP_DRV_ERR", "", CONV_DEFINE, API_FILE, 1}},
151150
{"IS_CUDA_ERR", {"IS_HIP_DRV_ERR", "", CONV_DEFINE, API_FILE, 1}},
152151
};
153152

@@ -275,7 +274,7 @@ const std::map<llvm::StringRef, cudaAPIversions> CUDA_FILE_TYPE_NAME_VER_MAP {
275274
{"CUFILE_PARAM_LOG_DIR", {CUFILE_1140, CUDA_0, CUDA_0}},
276275
{"IS_CUFILE_ERR", {CUFILE_1000, CUDA_0, CUDA_0}},
277276
{"CUFILE_ERRSTR", {CUFILE_1000, CUDA_0, CUDA_0}},
278-
{"CUDA_DRV_ERR", {CUDA_129, CUDA_0, CUDA_0}},
277+
{"CU_FILE_CUDA_ERR", {CUFILE_1000, CUDA_0, CUDA_0}},
279278
{"IS_CUDA_ERR", {CUFILE_1000, CUDA_0, CUDA_0}},
280279
};
281280

0 commit comments

Comments
 (0)