[Windows] add missing symbol export (#2556)

apwojcik · junliume · CAHEK7 · web-flow · commit 1cc63e29acfb · 2023-12-25T23:35:10.000-08:00
* add missing symbol export

* more missing exports

* fix format issues

---------

Co-authored-by: Jun Liu &lt;Liu.Jun@amd.com&gt;
Co-authored-by: Alex Eremin &lt;CAHEK7@yandex.ru&gt;
diff --git a/src/activ_api.cpp b/src/activ_api.cpp
@@ -70,6 +70,7 @@ extern "C" miopenStatus_t miopenGetActivationDescriptor(miopenActivationDescript
 }
 
 namespace miopen::debug {
+MIOPEN_EXPORT
 void LogCmdActivation(const miopen::TensorDescriptor& x_desc,
                       const miopen::ActivationDescriptor& activ_desc,
                       bool fwd)
diff --git a/src/execution_context.cpp b/src/execution_context.cpp
@@ -46,7 +46,8 @@ MIOPEN_DECLARE_ENV_VAR_BOOL(MIOPEN_DEBUG_AMD_ROCM_METADATA_PREFER_OLDER)
 namespace miopen {
 namespace debug {
 
-bool IsWarmupOngoing = false; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT bool IsWarmupOngoing = false;
 
 } // namespace debug
 } // namespace miopen
diff --git a/src/find_controls.cpp b/src/find_controls.cpp
@@ -48,7 +48,8 @@ namespace miopen {
 
 namespace debug {
 
-bool FindEnforceDisable = false; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT bool FindEnforceDisable = false;
 
 } // namespace debug
 
diff --git a/src/find_db.cpp b/src/find_db.cpp
@@ -40,7 +40,8 @@ namespace miopen {
 
 namespace debug {
 
-bool testing_find_db_enabled = true; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT bool testing_find_db_enabled = true;
 
 /// \todo Remove when #1723 is resolved.
 boost::optional<std::string>& testing_find_db_path_override()
diff --git a/src/include/miopen/conv_algo_name.hpp b/src/include/miopen/conv_algo_name.hpp
@@ -28,6 +28,7 @@
 
 #include <string>
 #include <miopen/errors.hpp>
+#include <miopen/export.h>
 
 namespace miopen {
 
@@ -46,6 +47,7 @@ miopenConvFwdAlgorithm_t StringToConvolutionFwdAlgo(const std::string& s);
 miopenConvBwdDataAlgorithm_t StringToConvolutionBwdDataAlgo(const std::string& s);
 miopenConvBwdWeightsAlgorithm_t StringToConvolutionBwdWeightsAlgo(const std::string& s);
 
+MIOPEN_EXPORT
 std::string ConvolutionAlgoToString(miopenConvAlgorithm_t algo);
 std::string ConvolutionAlgoToDirectionalString(miopenConvAlgorithm_t algo, conv::Direction dir);
 
diff --git a/src/include/miopen/convolution.hpp b/src/include/miopen/convolution.hpp
@@ -153,7 +153,7 @@ struct ConvolutionAttribute
     friend void from_json(const nlohmann::json& json, ConvolutionAttribute& conv);
 };
 
-struct ConvolutionDescriptor : miopenConvolutionDescriptor
+struct MIOPEN_EXPORT ConvolutionDescriptor : miopenConvolutionDescriptor
 {
     ConvolutionDescriptor(std::size_t spatial_dim,
                           miopenConvolutionMode_t c_mode,
diff --git a/src/include/miopen/execution_context.hpp b/src/include/miopen/execution_context.hpp
@@ -71,7 +71,8 @@ namespace debug {
 /// is in progress. The library can use this, for example, to disable some
 /// workarounds that would affect warm-up otherwise.
 /// WARNING: This switch is not intended for use in multi-threaded applications.
-extern bool IsWarmupOngoing; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT extern bool
+    IsWarmupOngoing; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
 
 } // namespace debug
 
diff --git a/src/include/miopen/find_controls.hpp b/src/include/miopen/find_controls.hpp
@@ -41,7 +41,8 @@ namespace debug {
 /// Disable MIOPEN_FIND_ENFORCE. Intended for debugging/testing purposes.
 /// Currently used during warm-up phase in MIOpenDriver.
 /// WARNING: This switch is not intended for use in multi-threaded applications.
-extern bool FindEnforceDisable; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT extern bool
+    FindEnforceDisable; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
 
 } // namespace debug
 
diff --git a/src/include/miopen/find_db.hpp b/src/include/miopen/find_db.hpp
@@ -66,8 +66,9 @@ using UserFindDbRecord = FindDbRecord_t<UserFindDb>;
 namespace debug {
 
 // For unit tests.
-extern bool testing_find_db_enabled; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
-extern boost::optional<std::string>&
+MIOPEN_EXPORT extern bool
+    testing_find_db_enabled; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT extern boost::optional<std::string>&
 testing_find_db_path_override(); /// \todo Remove when #1723 is resolved.
 
 } // namespace debug
diff --git a/src/include/miopen/gemm_v2.hpp b/src/include/miopen/gemm_v2.hpp
@@ -133,6 +133,7 @@ miopenStatus_t CallGemmTimeMeasure(const Handle& handle,
                                    CallGemmType_t call_gemm_type,
                                    GemmBackend_t gemm_backend = GemmBackend_t::rocblas);
 
+MIOPEN_EXPORT
 miopenStatus_t CallGemm(const Handle& handle,
                         GemmDescriptor gemm_desc,
                         ConstData_t A,
@@ -143,6 +144,7 @@ miopenStatus_t CallGemm(const Handle& handle,
                         std::size_t c_offset,
                         GemmBackend_t gemm_backend = GemmBackend_t::rocblas);
 
+MIOPEN_EXPORT
 miopenStatus_t CallGemmStridedBatched(const Handle& handle,
                                       GemmDescriptor gemm_desc,
                                       ConstData_t A,
diff --git a/src/include/miopen/handle.hpp b/src/include/miopen/handle.hpp
@@ -73,7 +73,7 @@ struct HandleImpl;
 using rocblas_handle_ptr = MIOPEN_MANAGE_PTR(rocblas_handle, rocblas_destroy_handle);
 #endif
 
-struct Handle : miopenHandle
+struct MIOPEN_EXPORT Handle : miopenHandle
 {
     friend struct TargetProperties;
 
diff --git a/src/include/miopen/logger.hpp b/src/include/miopen/logger.hpp
@@ -37,6 +37,7 @@
 #include <miopen/each_args.hpp>
 #include <miopen/object.hpp>
 #include <miopen/config.h>
+#include <miopen/export.h>
 
 #if MIOPEN_USE_ROCTRACER
 #include <roctracer/roctx.h>
@@ -212,16 +213,17 @@ namespace debug {
 /// by MIOPEN_LOG_NQ* macros (that ignore this switch).
 ///
 /// WARNING: This switch is not intended for use in multi-threaded applications.
-extern bool LoggingQuiet; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT extern bool
+    LoggingQuiet; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
 
 } // namespace debug
 
-const char* LoggingLevelToCString(LoggingLevel level);
-std::string LoggingPrefix();
+MIOPEN_EXPORT const char* LoggingLevelToCString(LoggingLevel level);
+MIOPEN_EXPORT std::string LoggingPrefix();
 
 /// \return true if level is enabled.
 /// \param level - one of the values defined in LoggingLevel.
-bool IsLogging(LoggingLevel level, bool disableQuieting = false);
+MIOPEN_EXPORT bool IsLogging(LoggingLevel level, bool disableQuieting = false);
 bool IsLoggingCmd();
 bool IsLoggingFunctionCalls();
 #if MIOPEN_USE_ROCTRACER
@@ -345,6 +347,7 @@ LogParam(std::ostream& os, std::string name, const std::vector<T>& vec, bool ind
 #define MIOPEN_LOG_FUNCTION(...)
 #endif
 
+MIOPEN_EXPORT
 std::string LoggingParseFunction(const char* func, const char* pretty_func);
 
 #define MIOPEN_GET_FN_NAME() \
diff --git a/src/include/miopen/pooling.hpp b/src/include/miopen/pooling.hpp
@@ -91,7 +91,7 @@ inline std::string get_pooling_index_type_max_name(miopenIndexType_t index_type)
 struct Handle;
 struct TensorDescriptor;
 
-struct PoolingDescriptor : miopenPoolingDescriptor
+struct MIOPEN_EXPORT PoolingDescriptor : miopenPoolingDescriptor
 {
     PoolingDescriptor();
 
diff --git a/src/include/miopen/solver.hpp b/src/include/miopen/solver.hpp
@@ -55,7 +55,7 @@ namespace debug {
 /// If set to true, then always enable ConvDirectNaive* solver, regardless of environment value
 /// MIOPEN_DEBUG_CONV_DIRECT_NAIVE_CONV_* that control enable/disable of these solvers.
 /// Currently used during driver using naive kernel as gpu reference.
-extern bool
+MIOPEN_EXPORT extern bool
     AlwaysEnableConvDirectNaive; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
 
 } // namespace debug
diff --git a/src/include/miopen/solver_id.hpp b/src/include/miopen/solver_id.hpp
@@ -56,7 +56,7 @@ enum class Primitive
     Reduce
 };
 
-struct Id
+struct MIOPEN_EXPORT Id
 {
     static constexpr uint64_t invalid_value = 0;
 
diff --git a/src/include/miopen/tensor.hpp b/src/include/miopen/tensor.hpp
@@ -123,7 +123,7 @@ std::ptrdiff_t integer_division_ceil(X x, Y y)
     return (tx + ty - 1) / ty;
 }
 
-struct TensorDescriptor : miopenTensorDescriptor
+struct MIOPEN_EXPORT TensorDescriptor : miopenTensorDescriptor
 {
     TensorDescriptor();
 
diff --git a/src/logger.cpp b/src/logger.cpp
@@ -68,7 +68,8 @@ namespace miopen {
 
 namespace debug {
 
-bool LoggingQuiet = false; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT bool LoggingQuiet = false;
 
 } // namespace debug
 
diff --git a/src/solver/conv_direct_naive_conv.cpp b/src/solver/conv_direct_naive_conv.cpp
@@ -40,7 +40,7 @@ namespace miopen {
 
 namespace debug {
 // NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
-bool AlwaysEnableConvDirectNaive = false;
+MIOPEN_EXPORT bool AlwaysEnableConvDirectNaive = false;
 
 } // namespace debug
 
diff --git a/test/gpu_conv.hpp b/test/gpu_conv.hpp
@@ -35,9 +35,10 @@
 namespace miopen {
 namespace debug {
 
-extern bool
+MIOPEN_EXPORT extern bool
     AlwaysEnableConvDirectNaive; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
-extern bool LoggingQuiet;        // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
+MIOPEN_EXPORT extern bool
+    LoggingQuiet; // NOLINT (cppcoreguidelines-avoid-non-const-global-variables)
 
 } // namespace debug
 } // namespace miopen

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ extern "C" miopenStatus_t miopenGetActivationDescriptor(miopenActivationDescript`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`namespace miopen::debug {`
	`73`	`+MIOPEN_EXPORT`
`73`	`74`	`void LogCmdActivation(const miopen::TensorDescriptor& x_desc,`
`74`	`75`	`const miopen::ActivationDescriptor& activ_desc,`
`75`	`76`	`bool fwd)`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ struct ConvolutionAttribute`
`153`	`153`	`friend void from_json(const nlohmann::json& json, ConvolutionAttribute& conv);`
`154`	`154`	`};`
`155`	`155`
`156`		`-struct ConvolutionDescriptor : miopenConvolutionDescriptor`
	`156`	`+struct MIOPEN_EXPORT ConvolutionDescriptor : miopenConvolutionDescriptor`
`157`	`157`	`{`
`158`	`158`	`ConvolutionDescriptor(std::size_t spatial_dim,`
`159`	`159`	`miopenConvolutionMode_t c_mode,`