Skip to content

Commit 80da7d5

Browse files
committed
Revert "hsakmt: Only set exec flag when requested"
This reverts commit 7514355. Reason for revert: This is currently breaking some tools. Will put it back as soon as tools update their code. Change-Id: I05c82d443f3a274a618d05e6dc5a87943f5dc7a4
1 parent d58c9de commit 80da7d5

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

libhsakmt/src/fmm.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1401,8 +1401,11 @@ static uint32_t fmm_translate_hsa_to_ioc_flags(HsaMemFlags flags)
14011401
KFD_IOC_ALLOC_MEM_FLAGS_UNCACHED);
14021402
if (!flags.ui32.ReadOnly)
14031403
ioc_flags |= KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE;
1404-
if (flags.ui32.ExecuteAccess)
1405-
ioc_flags |= KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE;
1404+
/* TODO: Since, ROCr interfaces doesn't allow caller to set page
1405+
* permissions, mark all user allocations with exec permission.
1406+
* Check for flags.ui32.ExecuteAccess once ROCr is ready.
1407+
*/
1408+
ioc_flags |= KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE;
14061409
return ioc_flags;
14071410
}
14081411

0 commit comments

Comments
 (0)