[Feature]: Building libhsakmt + kfdtest as part of ROCR-Runtime?

[ggankhuy]

Suggestion Description

With ROCT is merged to ROCR, it seems building ROCR still only generates libhsa-runtime.
While it may be possible to build aforementioned by doing into their respective directory, Will it be supported in the future that ROCT/kfdtest build as part of ROCR build?

cmake -DBUILD_SHARED_LIBS=on -DCMAKE_PREFIX_PATH=$CONFIG_INSTALL_PREFIX -DIMAGE_SUPPORT=OFF" ..
make -j
...
tree -fs <rocr_dir>\build | grep so

│   ├── libhsa-runtime64.so -> libhsa-runtime64.so.1
│   ├── libhsa-runtime64.so.1 -> libhsa-runtime64.so.1.14.0
│   └── libhsa-runtime64.so.1.14.0

Operating System

RHEL9

GPU

No response

ROCm Component

No response

[sohaibnd]

Hi @ggankhuy, if you build ROCR Runtime, libhsakmt does get built but as a static library:

which gets linked statically to the HSA runtime library, so you get a single shared (or static if you specify -DBUILD_SHARED_LIBS=off) library, which is the libhsa-runtime64.so you see.

kfdtest does not get built when you build ROCR Runtime, you have to go to libhsakmt/tests/kfdtest and follow the build instructions in the README.

Let me know if you have any other questions.

[ggankhuy]

ok so all APIs functions calls in libhsakmt is int libhsa-runtime? no longer libhsakmt.so? thx,

[sohaibnd]

Yes, there is no libhsakmt.so.

[sohaibnd]

@ggankhuy Closing this issue as it's resolved, feel free to re-open it if you have any follow-up questions.