Closed
Conversation
Currently, ROCr uses it's own FindLibElf.cmake module and this is inhibiting the build from finding the libelf config built by other build environments. Now we will first search in config mode and fallback to module mode if nothing is found.
Author
|
@estewart_amdeng I modified the commit message to be more generic rather than mention TheRock. Please let me know if you are not ok with that. |
Contributor
|
Imported to ROCm/rocm-systems#257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with TheRock build currently. They have a local source build of elfutils they want to use instead of a system package. Currently, rocr uses it's own FindLibElf.cmake module and this is inhibiting the build from finding the libelf config built by TheRock.
Now we will first search in config mode and fallback to module mode if nothing is found.