Update workflows to gcc-toolset-13 and fix OpenBLAS build (#1746)

- Update workflows to use new manylinux docker image produced by #1745
- For Linux, turn on `DYNAMIC_ARCH` for OpenBLAS build to resolve #83.
- `DYNAMIC_ARCH` support does not exist for MSVC and multi-arch support
for Windows seems shoddy overall. [Reference
1](OpenMathLib/OpenBLAS#2826 (comment))
and [Reference 2](OpenMathLib/OpenBLAS#3985)
- Remove usage of f2c version of an older lapack as it is considered
fallback option.
[Reference](OpenMathLib/OpenBLAS#4318 (comment))
- Patch amd-llvm compiler to be able to find stdc++ from gcc-toolset-13
during link time.

Author: jayhawk-commits

.github/workflows/build_portable_linux_artifacts.yml

@@ -40,7 +40,7 @@ jobs:
     permissions:
       id-token: write
     container:
-      image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:2f3ebd0beb04c449fdb36933e54bdc69483b914fb9005594d3fc9444c206b54b
+      image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:4443d9d710b9471e8ef658d509358bd92602498e67161b9280474bce0bb0decd
       options: -v /runner/config:/home/awsconfig/
     env:
       AWS_SHARED_CREDENTIALS_FILE: /home/awsconfig/credentials.ini

.github/workflows/build_portable_linux_python_packages.yml

@@ -45,7 +45,7 @@ jobs:
     # Note: GitHub-hosted runners run out of disk space for some gpu families
     runs-on: ${{ github.repository_owner == 'ROCm' && 'azure-linux-scale-rocm' || 'ubuntu-24.04' }}
     env:
-      BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:2f3ebd0beb04c449fdb36933e54bdc69483b914fb9005594d3fc9444c206b54b
+      BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:4443d9d710b9471e8ef658d509358bd92602498e67161b9280474bce0bb0decd
       ARTIFACT_RUN_ID: "${{ inputs.artifact_run_id != '' && inputs.artifact_run_id || github.run_id }}"
       ARTIFACTS_DIR: "${{ github.workspace }}/artifacts"
       PACKAGES_DIR: "${{ github.workspace }}/packages"

.github/workflows/build_portable_linux_pytorch_wheels.yml

@@ -104,7 +104,7 @@ jobs:
     name: Build | ${{ inputs.amdgpu_family }} | py ${{ inputs.python_version }} | torch ${{ inputs.pytorch_version }}
     runs-on: ${{ github.repository_owner == 'ROCm' && 'azure-linux-scale-rocm' || 'ubuntu-24.04' }}
     container:
-      image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:2f3ebd0beb04c449fdb36933e54bdc69483b914fb9005594d3fc9444c206b54b
+      image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:4443d9d710b9471e8ef658d509358bd92602498e67161b9280474bce0bb0decd
     env:
       OUTPUT_DIR: ${{ github.workspace }}/output
       PACKAGE_DIST_DIR: ${{ github.workspace }}/output/packages/dist

.github/workflows/release_portable_linux_packages.yml

@@ -145,7 +145,7 @@ jobs:
     env:
       TEATIME_LABEL_GH_GROUP: 1
       OUTPUT_DIR: ${{ github.workspace }}/output
-      BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:2f3ebd0beb04c449fdb36933e54bdc69483b914fb9005594d3fc9444c206b54b
+      BUILD_IMAGE: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:4443d9d710b9471e8ef658d509358bd92602498e67161b9280474bce0bb0decd
       DIST_ARCHIVE: "${{ github.workspace }}/output/therock-dist-linux-${{ matrix.target_bundle.amdgpu_family }}${{ inputs.package_suffix }}-${{ needs.setup_metadata.outputs.version }}.tar.gz"
       FILE_NAME: "therock-dist-linux-${{ matrix.target_bundle.amdgpu_family }}${{ inputs.package_suffix }}-${{ needs.setup_metadata.outputs.version }}.tar.gz"
       RELEASE_TYPE: "${{ needs.setup_metadata.outputs.release_type }}"

build_tools/linux_portable_build.py

@@ -128,7 +128,7 @@ def main(argv: list[str]):
     p.add_argument("--docker", default="docker", help="Docker or podman binary")
     p.add_argument(
         "--image",
-        default="ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:2f3ebd0beb04c449fdb36933e54bdc69483b914fb9005594d3fc9444c206b54b",
+        default="ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:4443d9d710b9471e8ef658d509358bd92602498e67161b9280474bce0bb0decd",
         help="Build docker image",
     )
     p.add_argument(

docs/environment_setup_guide.md

@@ -54,11 +54,11 @@ If having trouble building on a system, we will typically want to eliminate envi
 Our open-source binaries are typically built within a [manylinux container](https://github.com/pypa/manylinux) (see [the docker file](../dockerfiles/build_manylinux_x86_64.Dockerfile)). These images are versioned by the glibc version they target, and if dependencies are controlled carefully, binaries built on them should work on systems with the same or higher glibc version.
 
 Present version: glibc 2.28
-Based on upstream: AlmaLinux 8 with gcc toolset 12
+Based on upstream: AlmaLinux 8 with gcc toolset 13
 
 While this generally implies that the project should build on similarly versioned alternative EL distributions, do note that we install several upgraded tools (see dockerfile above) in our standard CI pipelines.
 
-Reference image: `ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:2f3ebd0beb04c449fdb36933e54bdc69483b914fb9005594d3fc9444c206b54b`
+Reference image: `ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:4443d9d710b9471e8ef658d509358bd92602498e67161b9280474bce0bb0decd`
 
 ### Ubuntu 22.04
 

patches/amd-mainline/llvm-project/0009-Add-gcc-toolset-13-prefix-detection.patch

@@ -0,0 +1,24 @@
+From b58aca008a73e791872fe77858b7e5748f6b1508 Mon Sep 17 00:00:00 2001
+From: Joseph Macaranas <[email protected]>
+Date: Thu, 9 Oct 2025 23:49:19 -0400
+Subject: [PATCH] Add gcc-toolset-13 prefix detection
+
+---
+ clang/lib/Driver/ToolChains/Gnu.cpp | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp
+index bf2a444520a2..fe2cb025a86c 100644
+--- a/clang/lib/Driver/ToolChains/Gnu.cpp
++++ b/clang/lib/Driver/ToolChains/Gnu.cpp
+@@ -2441,6 +2441,7 @@ void Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes(
+       D.getVFS().exists("/opt/rh")) {
+     // TODO: We may want to remove this, since the functionality
+     //   can be achieved using config files.
++    Prefixes.push_back("/opt/rh/gcc-toolset-13/root/usr");
+     Prefixes.push_back("/opt/rh/gcc-toolset-12/root/usr");
+     Prefixes.push_back("/opt/rh/gcc-toolset-11/root/usr");
+     Prefixes.push_back("/opt/rh/gcc-toolset-10/root/usr");
+--
+2.48.1
+

third-party/host-blas/CMakeLists.txt

@@ -30,6 +30,16 @@ if(NOT CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
       TOUCH "${_download_stamp}"
     )
 
+    # MSVC does not support VLA and AT&T assembly which are required by DYNAMIC_ARCH
+    # See: https://github.com/OpenMathLib/OpenBLAS/issues/2826#issuecomment-814170090
+    # Multi-arch support on Windows seems to be a problem not limited to MSVC
+    # See: https://github.com/OpenMathLib/OpenBLAS/issues/3985
+    if(WIN32)
+      set(_enable_dynamicArch "OFF")
+    else()
+      set(_enable_dynamicArch "ON")
+    endif()
+
     therock_cmake_subproject_declare(therock-host-blas
       BACKGROUND_BUILD
       EXCLUDE_FROM_ALL
@@ -45,10 +55,11 @@ if(NOT CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
       CMAKE_ARGS
         "-DSOURCE_DIR=${_source_dir}"
         -DBUILD_SHARED_LIBS=ON
-        # TODO: DYNAMIC_ARCH=ON produces illegal elf files
-        # See: https://github.com/ROCm/TheRock/issues/83
-        -DDYNAMIC_ARCH=OFF
-        -DC_LAPACK=ON
+        # https://github.com/OpenMathLib/OpenBLAS?tab=readme-ov-file#x86x86-64
+        # Picking HASWELL as a baseline that supports modern AMD and Intel CPUs
+        -DCMAKE_CROSSCOMPILING=ON
+        -DTARGET=HASWELL
+        -DDYNAMIC_ARCH=${_enable_dynamicArch}
         -DBUILD_TESTING=OFF
       EXTRA_DEPENDS
         "${_download_stamp}"