Skip to content

Commit 509ec09

Browse files
authored
Skip incompatible rocprofiler-systems submodules on Windows. (#93)
Progress on #36. This dependency which was added in #89 contains file paths that are not valid on Windows. Full error logs: https://gist.github.com/ScottTodd/0304483dca863cf6b8b74c15e14dbd85.
1 parent 79f7dc3 commit 509ec09

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

build_tools/fetch_sources.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import argparse
77
import os
88
from pathlib import Path
9+
import platform
910
import shlex
1011
import shutil
1112
import subprocess
@@ -17,6 +18,8 @@
1718
DEFAULT_SOURCES_DIR = THEROCK_DIR / "sources"
1819
PATCHES_DIR = THEROCK_DIR / "patches"
1920

21+
def is_windows() -> bool:
22+
return platform.system() == "Windows"
2023

2124
def setup_repo_tool() -> Path:
2225
"""Sets up https://gerrit.googlesource.com/git-repo/, downloading as needed."""
@@ -118,7 +121,14 @@ def populate_ancillary_sources(args):
118121
step to fixing the underlying software packages."""
119122
populate_submodules_if_exists(args.dir / "rocprofiler-register")
120123
populate_submodules_if_exists(args.dir / "rocprofiler-sdk")
121-
populate_submodules_if_exists(args.dir / "rocprofiler-systems")
124+
125+
# TODO(#36): Enable once rocprofiler-systems can be checked out on Windows
126+
# error: invalid path 'src/counter_analysis_toolkit/scripts/sample_data/L2_RQSTS:ALL_DEMAND_REFERENCES.data.reads.stat'
127+
# Upstream issues:
128+
# https://github.com/ROCm/rocprofiler-systems/issues/105
129+
# https://github.com/icl-utk-edu/papi/issues/321
130+
if not is_windows():
131+
populate_submodules_if_exists(args.dir / "rocprofiler-systems")
122132

123133

124134
def populate_submodules_if_exists(git_dir: Path):

0 commit comments

Comments
 (0)