Skip to content

Commit aa90fef

Browse files
marbrejharryma
authored andcommitted
Remove git-lfs from dependencies (#1814)
`git lfs` is no longer required with the switch to `dvc`.
1 parent 3427caf commit aa90fef

File tree

5 files changed

+1
-20
lines changed

5 files changed

+1
-20
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ instructions and configurations for alternatives.
5858
```bash
5959
# Install Ubuntu dependencies
6060
sudo apt update
61-
sudo apt install gfortran git git-lfs ninja-build cmake g++ pkg-config xxd patchelf automake libtool python3-venv python3-dev libegl1-mesa-dev
61+
sudo apt install gfortran git ninja-build cmake g++ pkg-config xxd patchelf automake libtool python3-venv python3-dev libegl1-mesa-dev
6262

6363
# Clone the repository
6464
git clone https://github.com/ROCm/TheRock.git

build_tools/hack/env_check/check_therock.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
CheckDisk(device_info=device),
1313
Check_Max_PATH_LIMIT(device_info=device),
1414
CheckGit(),
15-
CheckGitLFS(required=False),
1615
CheckCMake(),
1716
CheckCCache(required=False),
1817
CheckNinja(),
@@ -34,7 +33,6 @@
3433
CheckCPU(device_info=device),
3534
CheckDisk(device_info=device),
3635
CheckGit(),
37-
CheckGitLFS(required=True),
3836
CheckCMake(),
3937
CheckCCache(required=False),
4038
CheckNinja(),

build_tools/hack/env_check/check_tools.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -241,13 +241,6 @@ def __init__(self, required=True):
241241
self.name = "Git"
242242

243243

244-
class CheckGitLFS(CheckProgram):
245-
def __init__(self, required=True):
246-
super().__init__(required)
247-
self.program = FindGitLFS()
248-
self.name = "Git-LFS"
249-
250-
251244
class CheckUV(CheckProgram):
252245
def __init__(self, required=False):
253246
super().__init__(required)

build_tools/hack/env_check/find_tools.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,6 @@ def __init__(self):
174174
self.get_version()
175175

176176

177-
class FindGitLFS(FindProgram):
178-
def __init__(self):
179-
super().__init__()
180-
self.name = "git-lfs"
181-
self.get_version()
182-
183-
184177
class FindUV(FindProgram):
185178
def __init__(self):
186179
super().__init__()

build_tools/health_status.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ def main():
3939
CheckDisk(device_info=device),
4040
Check_Max_PATH_LIMIT(device_info=device) if device.is_windows else None,
4141
CheckGit(),
42-
CheckGitLFS(required=False)
43-
if device.is_windows
44-
else CheckGitLFS(required=True),
4542
CheckCMake(),
4643
CheckCCache(required=False),
4744
CheckNinja(),

0 commit comments

Comments
 (0)