From 8605b4220bbdb3ed00a07af354256b07c9b28703 Mon Sep 17 00:00:00 2001 From: Scott Date: Thu, 13 Feb 2025 19:04:00 -0800 Subject: [PATCH 1/2] Skip incompatible rocprofiler-systems submodules on Windows. --- build_tools/fetch_sources.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/build_tools/fetch_sources.py b/build_tools/fetch_sources.py index f55dedf67c..fe253b7e89 100755 --- a/build_tools/fetch_sources.py +++ b/build_tools/fetch_sources.py @@ -6,6 +6,7 @@ import argparse import os from pathlib import Path +import platform import shlex import shutil import subprocess @@ -17,6 +18,8 @@ DEFAULT_SOURCES_DIR = THEROCK_DIR / "sources" PATCHES_DIR = THEROCK_DIR / "patches" +def is_windows() -> bool: + return platform.system() == "Windows" def setup_repo_tool() -> Path: """Sets up https://gerrit.googlesource.com/git-repo/, downloading as needed.""" @@ -118,7 +121,11 @@ def populate_ancillary_sources(args): step to fixing the underlying software packages.""" populate_submodules_if_exists(args.dir / "rocprofiler-register") populate_submodules_if_exists(args.dir / "rocprofiler-sdk") - populate_submodules_if_exists(args.dir / "rocprofiler-systems") + + # TODO(#36): Enable once rocprofiler-systems can be checked out on Windows + # error: invalid path 'src/counter_analysis_toolkit/scripts/sample_data/L2_RQSTS:ALL_DEMAND_REFERENCES.data.reads.stat' + if not is_windows(): + populate_submodules_if_exists(args.dir / "rocprofiler-systems") def populate_submodules_if_exists(git_dir: Path): From d6832c7264b0e10a1232de6e0658af2e2dfaf540 Mon Sep 17 00:00:00 2001 From: Scott Date: Thu, 13 Feb 2025 11:30:00 -0800 Subject: [PATCH 2/2] Add links to upstream issues. --- build_tools/fetch_sources.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/build_tools/fetch_sources.py b/build_tools/fetch_sources.py index fe253b7e89..133cd2d9f4 100755 --- a/build_tools/fetch_sources.py +++ b/build_tools/fetch_sources.py @@ -124,6 +124,9 @@ def populate_ancillary_sources(args): # TODO(#36): Enable once rocprofiler-systems can be checked out on Windows # error: invalid path 'src/counter_analysis_toolkit/scripts/sample_data/L2_RQSTS:ALL_DEMAND_REFERENCES.data.reads.stat' + # Upstream issues: + # https://github.com/ROCm/rocprofiler-systems/issues/105 + # https://github.com/icl-utk-edu/papi/issues/321 if not is_windows(): populate_submodules_if_exists(args.dir / "rocprofiler-systems")