Skip to content

Commit 5f68a45

Browse files
committed
SWDEV-444098 - remove rocm-ocl-icd packaging
Change-Id: If0234ff03cf86e1f0435e743c1df75a3e179d48c Jenifer helped trigger a combined PSDB for the below three changes https://gerrit-git.amd.com/c/compute/ec/prototype/+/1020194 https://gerrit-git.amd.com/c/compute/ec/clr/+/1003601 https://gerrit-git.amd.com/c/compute/ec/OpenCL-ICD-Loader/+/1012373 Combined PSDB was successful: http://rocm-ci.amd.com/job/compute-psdb-staging/27382/ Change-Id: If0234ff03cf86e1f0435e743c1df75a3e179d48c
1 parent 96f5c44 commit 5f68a45

File tree

7 files changed

+20
-34
lines changed

7 files changed

+20
-34
lines changed

opencl/CMakeLists.txt

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ set(CMAKE_INSTALL_LIBDIR "lib" CACHE STRING "Library install directory")
1515
include(GNUInstallDirs)
1616

1717
option(BUILD_TESTS "Enable building OpenCL tests" OFF)
18-
option(BUILD_ICD "Enable building OpenCL ICD Loader" ON)
18+
option(BUILD_ICD "Enable building OpenCL ICD Loader" OFF)
1919
option(EMU_ENV "Enable building for emulation environment" OFF)
2020
option(FILE_REORG_BACKWARD_COMPATIBILITY "Enable File Reorganization backward compatibility" OFF)
2121

@@ -26,6 +26,10 @@ if(MSVC)
2626
endif()
2727

2828
set(OPENCL_ICD_LOADER_HEADERS_DIR "${CMAKE_CURRENT_LIST_DIR}/khronos/headers/opencl2.2" CACHE PATH "")
29+
30+
###--- Packaging ------------------------------------------------------------###
31+
32+
# DEV package
2933
if(BUILD_ICD)
3034
add_subdirectory(khronos/icd)
3135
else()
@@ -38,19 +42,6 @@ if(BUILD_TESTS)
3842
add_subdirectory(tests/ocltst)
3943
endif()
4044

41-
###--- Packaging ------------------------------------------------------------###
42-
43-
# DEV package
44-
install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/khronos/headers/opencl2.2/CL"
45-
DESTINATION include
46-
COMPONENT DEV
47-
PATTERN cl_d3d10.h EXCLUDE
48-
PATTERN cl_d3d11.h EXCLUDE
49-
PATTERN cl_dx9_media_sharing.h EXCLUDE
50-
PATTERN cl_egl.h EXCLUDE
51-
PERMISSIONS OWNER_WRITE OWNER_READ OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
52-
)
53-
5445
#############################
5546
# Packaging steps
5647
#############################

opencl/packaging/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,6 @@ install(TARGETS amdocl DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT asan)
2222
install(FILES ${opencl_SOURCE_DIR}/LICENSE.txt DESTINATION ${CMAKE_INSTALL_DOCDIR} COMPONENT binary)
2323
install(FILES ${opencl_SOURCE_DIR}/LICENSE.txt DESTINATION ${CMAKE_INSTALL_DOCDIR}-asan COMPONENT asan)
2424

25-
install(DIRECTORY ${opencl_SOURCE_DIR}/khronos/headers/opencl2.2/CL
26-
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} COMPONENT dev
27-
USE_SOURCE_PERMISSIONS
28-
PATTERN cl_d3d10.h EXCLUDE
29-
PATTERN cl_d3d11.h EXCLUDE
30-
PATTERN cl_dx9_media_sharing.h EXCLUDE )
3125

3226
if(BUILD_ICD)
3327
install(TARGETS OpenCL DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT icd )

opencl/tests/ocltst/env/CMakeLists.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ target_include_directories(ocltst
3434
PRIVATE
3535
$<TARGET_PROPERTY:Common,INTERFACE_INCLUDE_DIRECTORIES>)
3636

37-
target_link_libraries(ocltst
38-
PRIVATE
39-
OpenCL
40-
)
37+
target_link_libraries(ocltst PRIVATE OpenCL::OpenCL ${CMAKE_DL_LIBS})
38+
39+
if(NOT WIN32)
40+
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
41+
endif()
4142

4243
set_target_properties(ocltst PROPERTIES INSTALL_RPATH "$ORIGIN")
4344

opencl/tests/ocltst/module/gl/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ target_include_directories(oclgl
4545
PRIVATE
4646
$<TARGET_PROPERTY:Common,INTERFACE_INCLUDE_DIRECTORIES>)
4747

48-
target_link_libraries(oclgl
49-
PRIVATE
50-
OpenCL
48+
target_link_libraries(oclgl PRIVATE
5149
${GLEW_LIBRARIES}
5250
${OPENGL_LIBRARIES})
5351

opencl/tests/ocltst/module/perf/CMakeLists.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,10 @@ target_include_directories(oclperf
9595
PRIVATE
9696
$<TARGET_PROPERTY:Common,INTERFACE_INCLUDE_DIRECTORIES>)
9797

98-
target_link_libraries(oclperf
99-
PRIVATE
100-
OpenCL)
98+
target_link_libraries(oclperf PRIVATE OpenCL::OpenCL ${CMAKE_DL_LIBS})
99+
if(NOT WIN32)
100+
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
101+
endif()
101102

102103
add_custom_command(
103104
TARGET oclperf POST_BUILD

opencl/tests/ocltst/module/runtime/CMakeLists.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,10 @@ target_include_directories(oclruntime
6868
PRIVATE
6969
$<TARGET_PROPERTY:Common,INTERFACE_INCLUDE_DIRECTORIES>)
7070

71-
target_link_libraries(oclruntime
72-
PRIVATE
73-
OpenCL)
71+
target_link_libraries(oclruntime PRIVATE OpenCL::OpenCL ${CMAKE_DL_LIBS})
72+
if(NOT WIN32)
73+
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
74+
endif()
7475

7576
add_custom_command(
7677
TARGET oclruntime POST_BUILD

opencl/tools/clinfo/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ target_compile_definitions(clinfo PRIVATE CL_TARGET_OPENCL_VERSION=220 HAVE_CL2_
44

55
target_include_directories(clinfo PRIVATE ${OPENCL_ICD_LOADER_HEADERS_DIR})
66

7-
target_link_libraries(clinfo OpenCL)
7+
target_link_libraries(clinfo OpenCL::OpenCL)
88

99
INSTALL(TARGETS clinfo
1010
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

0 commit comments

Comments
 (0)