EXSWHTEC-83 - Implement additional negative parameter tests

music-dino · music-dino · commit 56b598280215 · 2022-10-04T14:44:21.000+02:00
diff --git a/tests/catch/unit/memory/hipMemAdvise.cc b/tests/catch/unit/memory/hipMemAdvise.cc
@@ -270,6 +270,12 @@ TEST_CASE("Unit_hipMemAdvise_Negative_Parameters") {
   }
   const auto advice = GENERATE(hipMemAdviseSetAccessedBy, hipMemAdviseSetReadMostly,
                                hipMemAdviseSetPreferredLocation);
+  SECTION("count == 0") {
+    HIP_CHECK_ERROR(hipMemAdvise(alloc.ptr(), 0, advice, device), hipErrorInvalidValue);
+  }
+  SECTION("count larger than allocation size") {
+    HIP_CHECK_ERROR(hipMemAdvise(alloc.ptr(), kPageSize + 1, advice, device), hipErrorInvalidValue);
+  }
   SECTION("dev_ptr == nullptr") {
     HIP_CHECK_ERROR(hipMemAdvise(nullptr, kPageSize, advice, device), hipErrorInvalidValue);
   }

Original file line number	Diff line number	Diff line change
`@@ -270,6 +270,12 @@ TEST_CASE("Unit_hipMemAdvise_Negative_Parameters") {`
`270`	`270`	`}`
`271`	`271`	`const auto advice = GENERATE(hipMemAdviseSetAccessedBy, hipMemAdviseSetReadMostly,`
`272`	`272`	`hipMemAdviseSetPreferredLocation);`
	`273`	`+ SECTION("count == 0") {`
	`274`	`+ HIP_CHECK_ERROR(hipMemAdvise(alloc.ptr(), 0, advice, device), hipErrorInvalidValue);`
	`275`	`+ }`
	`276`	`+ SECTION("count larger than allocation size") {`
	`277`	`+ HIP_CHECK_ERROR(hipMemAdvise(alloc.ptr(), kPageSize + 1, advice, device), hipErrorInvalidValue);`
	`278`	`+ }`
`273`	`279`	`SECTION("dev_ptr == nullptr") {`
`274`	`280`	`HIP_CHECK_ERROR(hipMemAdvise(nullptr, kPageSize, advice, device), hipErrorInvalidValue);`
`275`	`281`	`}`