Skip to content

Commit cb2eb15

Browse files
shraiyshGoogle-ML-Automation
authored andcommitted
PR jax-ml#22800: Change the default value of print_operand_shape_ to false and print_large_constants_ to true.
Imported from GitHub PR openxla/xla#22800 Operand shape in long hlo text adds redundant information, which shouldn't be required. Changing the default value to off. The large constants were also printed earlier by default print options, and it is required for parsability and reproducibility. Turning this on by default. This is still controlled by debug option and the default value of that flag disables the large constants, and that behavior is not changed. Just the default print options change here. Copybara import of the project: -- e30dea20489b3fb4d03d373fec0391d69486f4aa by Shraiysh Vaishay <[email protected]>: Change the default value of print_operand_shape_ to false and print_large_constants_ to true. Operand shape in long hlo text adds redundant information, which shouldn't be required. Changing the default value to off. The large constants were also printed earlier by default print options, and it is required for parsability and reproducibility. Turning this on by default. This is still controlled by debug option and the default value of that flag disables the large constants, and that behavior is not changed. Just the default print options change here. -- 7008af0dd0ce342ecbe9475f1d0e277319f1705a by Shraiysh Vaishay <[email protected]>: Handle tests -- b22d5f95cfb7e15f930a2198279a76c38593cc53 by Shraiysh Vaishay <[email protected]>: Fix more tests -- d51579cae7359c6426a87ad4a7ff1b4b0c80f74a by Shraiysh Vaishay <[email protected]>: Fix more tests Merging this change closes jax-ml#22800 PiperOrigin-RevId: 735690598
1 parent 76dec38 commit cb2eb15

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/memories_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1834,7 +1834,7 @@ def g(ys, _):
18341834
self.assertRegex(compiled_text, r"dynamic-update-slice-start.*S\(5\)")
18351835
self.assertRegex(compiled_text, r"dynamic-update-slice-done.*S\(5\)")
18361836
self.assertRegex(compiled_text, r"dynamic-slice-start.*S\(5\)")
1837-
self.assertRegex(compiled_text, r"dynamic-slice-done.*S\(5\)")
1837+
self.assertIn("dynamic-slice-start", compiled_text)
18381838

18391839
compiled_stats = compiled_f.memory_analysis()
18401840
if compiled_stats is not None:

0 commit comments

Comments
 (0)