[Driver] Use StringRef::consume_back (NFC) (llvm#139478)

kazutakahirata · web-flow · commit 20984d841d74 · 2025-05-11T17:03:50.000-07:00
diff --git a/clang/lib/Driver/ToolChains/Darwin.cpp b/clang/lib/Driver/ToolChains/Darwin.cpp
@@ -1411,8 +1411,8 @@ StringRef Darwin::getSDKName(StringRef isysroot) {
   auto EndSDK = llvm::sys::path::rend(isysroot);
   for (auto IT = BeginSDK; IT != EndSDK; ++IT) {
     StringRef SDK = *IT;
-    if (SDK.ends_with(".sdk"))
-        return SDK.slice(0, SDK.size() - 4);
+    if (SDK.consume_back(".sdk"))
+      return SDK;
   }
   return "";
 }

Original file line number	Diff line number	Diff line change
`@@ -1411,8 +1411,8 @@ StringRef Darwin::getSDKName(StringRef isysroot) {`
`1411`	`1411`	`auto EndSDK = llvm::sys::path::rend(isysroot);`
`1412`	`1412`	`for (auto IT = BeginSDK; IT != EndSDK; ++IT) {`
`1413`	`1413`	`StringRef SDK = *IT;`
`1414`		`- if (SDK.ends_with(".sdk"))`
`1415`		`- return SDK.slice(0, SDK.size() - 4);`
	`1414`	`+ if (SDK.consume_back(".sdk"))`
	`1415`	`+ return SDK;`
`1416`	`1416`	`}`
`1417`	`1417`	`return "";`
`1418`	`1418`	`}`