Fix handling of error values

Author: adelejjeh

offload/plugins-nextgen/common/src/PluginInterface.cpp

@@ -1891,7 +1891,13 @@ void *GenericDeviceTy::getFree_ArgBuf(size_t sz) {
     }
   }
   if (!found_ptr) {
-    found_ptr = this->allocate(sz, &found_ptr, TARGET_ALLOC_SHARED);
+    auto AllocOrErr = this->allocate(sz, nullptr, TARGET_ALLOC_SHARED);
+    if (!AllocOrErr) {
+      REPORT("Could not get SHARED mem for Arg Buffer: %s\n",
+             toString(AllocOrErr.takeError()).data());
+      return nullptr;
+    }
+    found_ptr = *AllocOrErr;
     assert(found_ptr && "Could not get SHARED mem for Arg Buffer\n");
     ArgBufEntryTy *new_entry_ptr = new ArgBufEntryTy;
     new_entry_ptr->Size = sz;
@@ -1915,7 +1921,7 @@ void GenericDeviceTy::moveBusyToFree_ArgBuf(void *ptr) {
 }
 void GenericDeviceTy::clear_ArgBufs() {
   for (auto entry : ArgBufEntries) {
-    this->free(entry->Addr, TARGET_ALLOC_SHARED);
+    consumeError(this->free(entry->Addr, TARGET_ALLOC_SHARED));
     delete entry;
   }
   ArgBufEntries.clear();

offload/plugins-nextgen/common/src/RPC.cpp

@@ -70,15 +70,23 @@ rpc::Status handleOffloadOpcodes(plugin::GenericDeviceTy &Device,
 #ifdef OFFLOAD_ENABLE_EMISSARY_APIS
   case ALT_LIBC_MALLOC: {
     Port.recv_and_send([&](rpc::Buffer *Buffer, uint32_t) {
-      Buffer->data[0] = reinterpret_cast<uintptr_t>(
-          Device.allocate(Buffer->data[0], nullptr, TARGET_ALLOC_DEVICE));
+      auto PtrOrErr =
+          Device.allocate(Buffer->data[0], nullptr, TARGET_ALLOC_DEVICE);
+      void *Ptr = nullptr;
+      if (!PtrOrErr)
+        consumeError(PtrOrErr.takeError());
+      else
+        Ptr = *PtrOrErr;
+      Buffer->data[0] = reinterpret_cast<uintptr_t>(Ptr);
     });
     break;
   }
   case ALT_LIBC_FREE: {
     Port.recv([&](rpc::Buffer *Buffer, uint32_t) {
-      Device.free(reinterpret_cast<void *>(Buffer->data[0]),
-                  TARGET_ALLOC_DEVICE);
+      if (auto Error = Device.free(reinterpret_cast<void *>(Buffer->data[0]),
+                                   TARGET_ALLOC_DEVICE)) {
+        consumeError(std::move(Error));
+      }
     });
     break;
   }