Skip to content

Commit 3310c0b

Browse files
authored
[VPlan] Strip TODO to consolidate (ActiveLaneMask|Widen)PHI (llvm#171392)
They cannot be consolidated, as WidenPHI is not a header PHI, while ActtiveLaneMaskPHI is.
1 parent d86bc19 commit 3310c0b

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

llvm/lib/Transforms/Vectorize/VPlan.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3600,8 +3600,6 @@ class VPCanonicalIVPHIRecipe : public VPHeaderPHIRecipe {
36003600

36013601
/// A recipe for generating the active lane mask for the vector loop that is
36023602
/// used to predicate the vector operations.
3603-
/// TODO: It would be good to use the existing VPWidenPHIRecipe instead and
3604-
/// remove VPActiveLaneMaskPHIRecipe.
36053603
class VPActiveLaneMaskPHIRecipe : public VPHeaderPHIRecipe {
36063604
public:
36073605
VPActiveLaneMaskPHIRecipe(VPValue *StartMask, DebugLoc DL)

llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4407,8 +4407,6 @@ void VPWidenPHIRecipe::printRecipe(raw_ostream &O, const Twine &Indent,
44074407
}
44084408
#endif
44094409

4410-
// TODO: It would be good to use the existing VPWidenPHIRecipe instead and
4411-
// remove VPActiveLaneMaskPHIRecipe.
44124410
void VPActiveLaneMaskPHIRecipe::execute(VPTransformState &State) {
44134411
BasicBlock *VectorPH =
44144412
State.CFG.VPBB2IRBB.at(getParent()->getCFGPredecessor(0));

0 commit comments

Comments
 (0)