Skip to content

Commit 339fa3f

Browse files
Merge pull request #78 from david-salinas/hipcc_clean_up
Hipcc clean up
2 parents 85965b8 + 1e8b07a commit 339fa3f

File tree

5 files changed

+21
-5
lines changed

5 files changed

+21
-5
lines changed

amd/hipcc/CMakeLists.txt

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE.txt")
5555

5656
# Debian-specific packaging variables.
5757
set(CPACK_DEBIAN_FILE_NAME "DEB-DEFAULT")
58-
set(CPACK_DEBIAN_PACKAGE_DEPENDS "hip-dev, libfile-basedir-perl, libfile-copy-recursive-perl, libfile-listing-perl, libfile-which-perl, liburi-encode-perl, perl (>= 5.0), rocm-core, rocm-llvm")
58+
set(CPACK_DEBIAN_PACKAGE_DEPENDS "perl (>= 5.0), libfile-basedir-perl, hip-dev, rocm-core, rocm-llvm")
5959
set(CPACK_DEBIAN_PACKAGE_HOMEPAGE "https://github.com/ROCm-Developer-Tools/HIPCC")
6060
if(DEFINED ENV{CPACK_DEBIAN_PACKAGE_RELEASE})
6161
set(CPACK_DEBIAN_PACKAGE_RELEASE $ENV{CPACK_DEBIAN_PACKAGE_RELEASE})
@@ -66,8 +66,8 @@ endif()
6666
# RPM-specific packaging variables.
6767
set(CPACK_RPM_FILE_NAME "RPM-DEFAULT")
6868
set(CPACK_RPM_PACKAGE_LICENSE "MIT")
69-
set(CPACK_RPM_PACKAGE_REQUIRES "hip-devel, perl >= 5.0, perl-File-BaseDir, perl-File-Listing, perl-File-Which, perl-URI-Encode, rocm-core, rocm-llvm")
70-
set(CPACK_RPM_PACKAGE_AUTOPROV 0)
69+
set(CPACK_RPM_PACKAGE_REQUIRES "perl >= 5.0, perl-File-BaseDir, hip-devel, rocm-core, rocm-llvm")
70+
set(CPACK_RPM_PACKAGE_AUTOREQROV 0)
7171
if(DEFINED ENV{CPACK_RPM_PACKAGE_RELEASE})
7272
set(CPACK_RPM_PACKAGE_RELEASE $ENV{CPACK_RPM_PACKAGE_RELEASE})
7373
else()
@@ -88,18 +88,31 @@ else()
8888
endif()
8989
set(CPACK_PACKAGE_VERSION "${CPACK_PACKAGE_VERSION_MAJOR}.${CPACK_PACKAGE_VERSION_MINOR}.${CPACK_PACKAGE_VERSION_PATCH}.${ROCM_VERSION_FOR_PACKAGE}")
9090

91+
# Exclude Windows specific BAT scripts from install/packaging for Linux.
92+
if (NOT WIN32)
93+
set(exclusion_pattern "*.bat")
94+
else ()
95+
set(exclusion_pattern "")
96+
endif()
97+
9198
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/bin
9299
DESTINATION .
93100
USE_SOURCE_PERMISSIONS
94-
DIRECTORY_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE)
101+
DIRECTORY_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
102+
FILES_MATCHING
103+
PATTERN "*"
104+
PATTERN ${exclusion_pattern} EXCLUDE )
105+
95106
install(FILES
96107
"LICENSE.txt"
97108
"README.md"
98109
COMPONENT ${hipcc_NAME}
99110
DESTINATION ${CMAKE_INSTALL_DOCDIR})
111+
100112
install(TARGETS ${HIPCC_BIN}
101113
COMPONENT ${hipcc_NAME}
102114
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})
115+
103116
install(TARGETS ${HIPCONFIG_BIN}
104117
COMPONENT ${hipcc_NAME}
105118
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

amd/hipcc/bin/hipcc.bat

100644100755
File mode changed.

amd/hipcc/bin/hipcc.pl

100644100755
File mode changed.

amd/hipcc/bin/hipconfig.bat

100644100755
File mode changed.

amd/hipcc/hipcc-backward-compat.cmake

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,7 @@ endfunction()
3939
# Create symlink to binaries
4040
create_binary_symlink()
4141
# TODO: Following has to modified if component based installation is required
42-
install(DIRECTORY ${HIPCC_WRAPPER_BIN_DIR} DESTINATION hip)
42+
install(DIRECTORY ${HIPCC_WRAPPER_BIN_DIR} DESTINATION hip
43+
FILES_MATCHING
44+
PATTERN "*"
45+
PATTERN ${exclusion_pattern} EXCLUDE )

0 commit comments

Comments
 (0)