Skip to content

Commit 4c5817d

Browse files
authored
Merge pull request #102 from AMD-Lightning-Internal/amd/dev/rlieberm/CG-flip-OMPX_DISABLE_USM_MAPS
[Offload][AMDGPU] Flip OMPX_DISABLE_USM_MAPS default value
2 parents a64da03 + 63cae8e commit 4c5817d

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

offload/plugins-nextgen/amdgpu/src/rtl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2678,7 +2678,7 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
26782678
// setting default to true here appears to solve random sdma problem
26792679
"LIBOMPTARGET_AMDGPU_USE_MULTIPLE_SDMA_ENGINES", false),
26802680
OMPX_ApuMaps("OMPX_APU_MAPS", false),
2681-
OMPX_DisableUsmMaps("OMPX_DISABLE_USM_MAPS", false),
2681+
OMPX_DisableUsmMaps("OMPX_DISABLE_USM_MAPS", true),
26822682
OMPX_NoMapChecks("OMPX_DISABLE_MAPS", true),
26832683
OMPX_StrictSanityChecks("OMPX_STRICT_SANITY_CHECKS", false),
26842684
OMPX_SyncCopyBack("LIBOMPTARGET_SYNC_COPY_BACK", true),

offload/test/mapping/coarse_grain.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
// clang-format off
22
// RUN: %libomptarget-compilexx-generic
33
// RUN: env HSA_XNACK=1 LIBOMPTARGET_INFO=30 %libomptarget-run-generic 2>&1 \
4-
// RUN: | %fcheck-generic -check-prefix=CHECK
4+
// RUN: | %fcheck-generic -check-prefix=CHECK_FINE
55

66
// RUN: %libomptarget-compilexx-generic
77
// RUN: env OMPX_DISABLE_USM_MAPS=1 HSA_XNACK=1 LIBOMPTARGET_INFO=30 %libomptarget-run-generic 2>&1 \
88
// RUN: | %fcheck-generic -check-prefix=CHECK_FINE
99

10+
// RUN: %libomptarget-compilexx-generic
11+
// RUN: env OMPX_DISABLE_USM_MAPS=0 HSA_XNACK=1 LIBOMPTARGET_INFO=30 %libomptarget-run-generic 2>&1 \
12+
// RUN: | %fcheck-generic -check-prefix=CHECK
13+
1014
// UNSUPPORTED: aarch64-unknown-linux-gnu
1115
// UNSUPPORTED: aarch64-unknown-linux-gnu-LTO
1216
// UNSUPPORTED: nvptx64-nvidia-cuda

0 commit comments

Comments
 (0)