Fix all compile warnings (llvm#2832)

Most are about unused variables and functions.

Author: shiltian

clang/lib/Sema/SemaExpr.cpp

@@ -15540,38 +15540,6 @@ static bool isOverflowingIntegerType(ASTContext &Ctx, QualType T) {
   return Ctx.getIntWidth(T) >= Ctx.getIntWidth(Ctx.IntTy);
 }
 
-static Expr *ExpandAMDGPUPredicateBI(ASTContext &Ctx, CallExpr *CE) {
-  if (!CE->getBuiltinCallee())
-    return CXXBoolLiteralExpr::Create(Ctx, false, Ctx.BoolTy, CE->getExprLoc());
-
-  if (Ctx.getTargetInfo().getTriple().isSPIRV()) {
-    CE->setType(Ctx.getLogicalOperationType());
-    return CE;
-  }
-
-  bool P = false;
-  auto &TI = Ctx.getTargetInfo();
-
-  if (CE->getDirectCallee()->getName() == "__builtin_amdgcn_processor_is") {
-    auto *GFX = dyn_cast<StringLiteral>(CE->getArg(0)->IgnoreParenCasts());
-    auto TID = TI.getTargetID();
-    if (GFX && TID) {
-      auto N = GFX->getString();
-      P = TI.isValidCPUName(GFX->getString()) && TID->find(N) == 0;
-    }
-  } else {
-    auto *FD = cast<FunctionDecl>(CE->getArg(0)->getReferencedDeclOfCallee());
-
-    StringRef RF = Ctx.BuiltinInfo.getRequiredFeatures(FD->getBuiltinID());
-    llvm::StringMap<bool> CF;
-    Ctx.getFunctionFeatureMap(CF, FD);
-
-    P = Builtin::evaluateRequiredTargetFeatures(RF, CF);
-  }
-
-  return CXXBoolLiteralExpr::Create(Ctx, P, Ctx.BoolTy, CE->getExprLoc());
-}
-
 ExprResult Sema::CreateBuiltinUnaryOp(SourceLocation OpLoc,
                                       UnaryOperatorKind Opc, Expr *InputExpr,
                                       bool IsAfterAmp) {
@@ -20465,88 +20433,6 @@ void Sema::DiagnoseEqualityWithExtraParens(ParenExpr *ParenE) {
     }
 }
 
-static bool ValidateAMDGPUPredicateBI(Sema &Sema, CallExpr *CE) {
-  if (CE->getDirectCallee()->getName() == "__builtin_amdgcn_processor_is") {
-    auto *GFX = dyn_cast<StringLiteral>(CE->getArg(0)->IgnoreParenCasts());
-    if (!GFX) {
-      Sema.Diag(CE->getExprLoc(),
-                diag::err_amdgcn_processor_is_arg_not_literal);
-      return false;
-    }
-    auto N = GFX->getString();
-    if (!Sema.getASTContext().getTargetInfo().isValidCPUName(N) &&
-        (!Sema.getASTContext().getAuxTargetInfo() ||
-         !Sema.getASTContext().getAuxTargetInfo()->isValidCPUName(N))) {
-      Sema.Diag(CE->getExprLoc(),
-                diag::err_amdgcn_processor_is_arg_invalid_value)
-          << N;
-      return false;
-    }
-  } else {
-    auto *Arg = CE->getArg(0);
-    if (!Arg || Arg->getType() != Sema.getASTContext().BuiltinFnTy) {
-      Sema.Diag(CE->getExprLoc(),
-                diag::err_amdgcn_is_invocable_arg_invalid_value)
-          << Arg;
-      return false;
-    }
-  }
-
-  return true;
-}
-
-static Expr *MaybeHandleAMDGPUPredicateBI(Sema &Sema, Expr *E, bool &Invalid) {
-  if (auto *UO = dyn_cast<UnaryOperator>(E)) {
-    auto *SE = dyn_cast<CallExpr>(UO->getSubExpr());
-    if (IsAMDGPUPredicateBI(SE)) {
-      assert(UO->getOpcode() == UnaryOperator::Opcode::UO_LNot &&
-             "__builtin_amdgcn_processor_is and __builtin_amdgcn_is_invocable "
-             "can only be used as operands of logical ops!");
-
-      if (!ValidateAMDGPUPredicateBI(Sema, SE)) {
-        Invalid = true;
-        return nullptr;
-      }
-
-      UO->setSubExpr(ExpandAMDGPUPredicateBI(Sema.getASTContext(), SE));
-      UO->setType(Sema.getASTContext().getLogicalOperationType());
-
-      return UO;
-    }
-  }
-  if (auto *BO = dyn_cast<BinaryOperator>(E)) {
-    auto *LHS = dyn_cast<CallExpr>(BO->getLHS());
-    auto *RHS = dyn_cast<CallExpr>(BO->getRHS());
-    if (IsAMDGPUPredicateBI(LHS) && IsAMDGPUPredicateBI(RHS)) {
-      assert(BO->isLogicalOp() &&
-             "__builtin_amdgcn_processor_is and __builtin_amdgcn_is_invocable "
-             "can only be used as operands of logical ops!");
-
-      if (!ValidateAMDGPUPredicateBI(Sema, LHS) ||
-          !ValidateAMDGPUPredicateBI(Sema, RHS)) {
-        Invalid = true;
-        return nullptr;
-      }
-
-      BO->setLHS(ExpandAMDGPUPredicateBI(Sema.getASTContext(), LHS));
-      BO->setRHS(ExpandAMDGPUPredicateBI(Sema.getASTContext(), RHS));
-      BO->setType(Sema.getASTContext().getLogicalOperationType());
-
-      return BO;
-    }
-  }
-  if (auto *CE = dyn_cast<CallExpr>(E))
-    if (IsAMDGPUPredicateBI(CE)) {
-      if (!ValidateAMDGPUPredicateBI(Sema, CE)) {
-        Invalid = true;
-        return nullptr;
-      }
-      return ExpandAMDGPUPredicateBI(Sema.getASTContext(), CE);
-    }
-
-  return nullptr;
-}
-
 ExprResult Sema::CheckBooleanCondition(SourceLocation Loc, Expr *E,
                                        bool IsConstexpr) {
   DiagnoseAssignmentAsCondition(E);

compiler-rt/lib/asan/asan_errors.cpp

@@ -737,14 +737,14 @@ static uptr ScanForMagicUp(uptr start, uptr hi, uptr magic0, uptr magic1) {
 
 void ErrorNonSelfAMDGPU::PrintMallocStack() {
   // Facts about asan malloc on device
-  const uptr magic = 0xfedcba1ee1abcdefULL;
+  const uptr magic = static_cast<uptr>(0xfedcba1ee1abcdefULL);
   const uptr offset = 32;
   const uptr min_chunk_size = 96;
   const uptr min_alloc_size = 48;
 
   Decorator d;
   HeapAddressDescription addr_description;
-  
+
   if (GetHeapAddressInformation(device_address[0], access_size,
               &addr_description) &&
       addr_description.chunk_access.chunk_size >= min_chunk_size) {

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

@@ -2018,7 +2018,7 @@ void DwarfDebug::collectEntityInfo(DwarfCompileUnit &TheCU,
             if (ProcessedLifetimes.insert(L).second) {
               if (auto *AddCU = dyn_cast<DICompileUnit>(GV->getScope())) {
                 AddCULifetimeMap[AddCU].push_back(L);
-              } else if (auto *AddNS = dyn_cast<DINamespace>(GV->getScope())) {
+              } else if (isa<DINamespace>(GV->getScope())) {
                 // FIXME(KZHURAVL): Properly support DINamespace.
               } else if (auto *AddSP = dyn_cast<DISubprogram>(GV->getScope())) {
                 SPLifetimeMap[AddSP].push_back(L);

llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp

@@ -991,11 +991,9 @@ std::optional<NewOpResult> DwarfExpression::traverse(DIOp::Arg Arg,
     if (IsFragment)
       emitOp(dwarf::DW_OP_lit0);
 
-    unsigned RegSize = 0;
     for (auto &Reg : Regs) {
       if (Reg.SubRegSize % 8)
         return std::nullopt;
-      RegSize += Reg.SubRegSize;
       if (Reg.DwarfRegNo >= 0)
         addReg(Reg.DwarfRegNo, Reg.Comment);
       emitOp(dwarf::DW_OP_piece);

llvm/lib/CodeGen/SelectionDAG/FastISel.cpp

@@ -1443,7 +1443,7 @@ bool FastISel::selectIntrinsicCall(const IntrinsicInst *II) {
     const DbgDefInst &DDI = *cast<DbgDefInst>(II);
     const Value *Referrer = DDI.getReferrer();
     assert(Referrer);
-    if (const auto *UV = dyn_cast<UndefValue>(Referrer)) {
+    if (isa<UndefValue>(Referrer)) {
       BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, MIMD,
               TII.get(TargetOpcode::DBG_DEF))
           .addMetadata(DDI.getLifetime())

llvm/lib/Debuginfod/Debuginfod.cpp

@@ -305,7 +305,7 @@ Expected<std::string> getCachedOrDownloadArtifact(
       Error Err = Client.perform(Request, Handler);
       if (Err)
         return std::move(Err);
-      if (Err = Handler.commit())
+      if ((Err = Handler.commit()))
         return std::move(Err);
 
       unsigned Code = Client.responseCode();

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

@@ -209,27 +209,6 @@ static Error dumpSectionToFile(StringRef SecName, StringRef Filename,
                            SecName.str().c_str());
 }
 
-static Error dumpRawDataURIToFile(StringRef Filename, int64_t Offset,
-                                  int64_t Size, ObjectFile &Obj) {
-  SmallString<2048> NameBuf;
-  raw_svector_ostream OutputFileName(NameBuf);
-  OutputFileName << Obj.getFileName().str() << "-offset" << Offset << "-size"
-                 << Size << ".co";
-
-  Expected<std::unique_ptr<FileOutputBuffer>> BufferOrErr =
-      FileOutputBuffer::create(OutputFileName.str(), Size);
-
-  if (!BufferOrErr)
-    return BufferOrErr.takeError();
-
-  MemoryBufferRef Input = Obj.getMemoryBufferRef();
-  std::unique_ptr<FileOutputBuffer> Buf = std::move(*BufferOrErr);
-  std::copy(Input.getBufferStart(), Input.getBufferStart() + Size,
-            Buf->getBufferStart());
-
-  return Buf->commit();
-}
-
 Error Object::compressOrDecompressSections(const CommonConfig &Config) {
   // Build a list of sections we are going to replace.
   // We can't call `addSection` while iterating over sections,

llvm/tools/llvm-objcopy/ObjcopyOptions.cpp

@@ -286,7 +286,7 @@ static Expected<uint8_t> parseVisibilityType(StringRef VisType) {
   return type;
 }
 
-static void llvm::objcopy::parseDumpOffloadBundle(StringRef URI) {
+static void parseDumpOffloadBundle(StringRef URI) {
   if (Error Err = object::extractOffloadBundleByURI(URI))
     outs() << "Failed to extract from URI.";
 }
@@ -758,9 +758,8 @@ objcopy::parseObjcopyOptions(ArrayRef<const char *> ArgsArr,
                              "too many positional arguments");
 
   if (Arg *A = InputArgs.getLastArg(OBJCOPY_dump_offload_bundle)) {
-    for (StringRef URIStr : llvm::split(A->getValue(), ",")) {
-      llvm::objcopy::parseDumpOffloadBundle(URIStr);
-    }
+    for (StringRef URIStr : llvm::split(A->getValue(), ","))
+      parseDumpOffloadBundle(URIStr);
   }
 
   if (Config.NeedPositional) {

llvm/tools/llvm-objcopy/ObjcopyOptions.h

@@ -51,11 +51,6 @@ parseBitcodeStripOptions(ArrayRef<const char *> ArgsArr,
 Expected<DriverConfig>
 parseStripOptions(ArrayRef<const char *> ArgsArr,
                   llvm::function_ref<Error(Error)> ErrorCallback);
-
-// parseDumpURI reads a URI as a string, and extracts the raw memory into a
-// code object file named from the URI string given
-static void parseDumpOffloadBundle(StringRef URI);
-
 } // namespace objcopy
 } // namespace llvm