Skip to content

Commit 57025b4

Browse files
committed
[SLP]Mark smin reduction as signed compare
Reduction signed min must be marked as signed compare, fixing the analysis for the cases, where the incoming arguments are unsigned. Fixes llvm#133943
1 parent 5529024 commit 57025b4

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20170,6 +20170,10 @@ void BoUpSLP::computeMinimumValueSizes() {
2017020170
IsTruncRoot = true;
2017120171
}
2017220172
bool IsSignedCmp = false;
20173+
if (UserIgnoreList && all_of(*UserIgnoreList, [](Value *V) {
20174+
return match(V, m_SMin(m_Value(), m_Value()));
20175+
}))
20176+
IsSignedCmp = true;
2017320177
while (NodeIdx < VectorizableTree.size()) {
2017420178
ArrayRef<Value *> TreeRoot = VectorizableTree[NodeIdx]->Scalars;
2017520179
unsigned Limit = 2;

llvm/test/Transforms/SLPVectorizer/RISCV/smin-reduction-unsigned-missing-sign.ll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ define i32 @test(i8 %0) {
77
; CHECK-NEXT: [[ENTRY:.*:]]
88
; CHECK-NEXT: [[TMP1:%.*]] = insertelement <4 x i8> <i8 poison, i8 0, i8 0, i8 0>, i8 [[TMP0]], i32 0
99
; CHECK-NEXT: [[TMP2:%.*]] = icmp ne <4 x i8> [[TMP1]], zeroinitializer
10-
; CHECK-NEXT: [[TMP3:%.*]] = call i1 @llvm.vector.reduce.smin.v4i1(<4 x i1> [[TMP2]])
11-
; CHECK-NEXT: [[TMP4:%.*]] = zext i1 [[TMP3]] to i32
10+
; CHECK-NEXT: [[TMP3:%.*]] = zext <4 x i1> [[TMP2]] to <4 x i8>
11+
; CHECK-NEXT: [[TMP5:%.*]] = call i8 @llvm.vector.reduce.smin.v4i8(<4 x i8> [[TMP3]])
12+
; CHECK-NEXT: [[TMP4:%.*]] = zext i8 [[TMP5]] to i32
1213
; CHECK-NEXT: ret i32 [[TMP4]]
1314
;
1415
entry:

0 commit comments

Comments
 (0)