Skip to content

Commit 61e5854

Browse files
authored
[runtimes] - Use extra_cmake_args for rocr/rocm-device-libs external … (llvm#3115)
2 parents dec49e5 + b6894a3 commit 61e5854

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

llvm/runtimes/CMakeLists.txt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,9 @@ if(build_runtimes)
522522
if("openmp" IN_LIST LLVM_ENABLE_RUNTIMES OR "offload" IN_LIST LLVM_ENABLE_RUNTIMES)
523523
# With ROCm 6.3 the ROCr runtime and the thunk layer share a single repository.
524524
# No need to provide a separate path for ROCt.
525+
if (OFFLOAD_EXTERNAL_PROJECT_UNIFIED_ROCR OR DEFINED LIBOMPTARGET_EXTERNAL_PROJECT_ROCM_DEVICE_LIBS_PATH)
526+
list(APPEND extra_cmake_args "-DCMAKE_PREFIX_PATH=${CMAKE_BINARY_DIR}/lib/cmake;${CMAKE_PREFIX_PATH}")
527+
endif()
525528
if (OFFLOAD_EXTERNAL_PROJECT_UNIFIED_ROCR)
526529
if(NOT DEFINED LIBOMPTARGET_EXTERNAL_PROJECT_HSA_PATH)
527530
message(SEND_ERROR "External ROCr requires setting LIBOMPTARGET_EXTERNAL_PROJECT_HSA_PATH")
@@ -533,9 +536,9 @@ if(build_runtimes)
533536
DEPENDS clang llvm-link lld opt llvm-objcopy
534537
INSTALL_COMMAND ""
535538
CMAKE_ARGS -DBUILD_SHARED_LIBS=ON
536-
-DCMAKE_PREFIX_PATH=${CMAKE_BINARY_DIR}/lib/cmake
537539
-DIMAGE_SUPPORT=OFF
538-
-DLLVM_RUNTIME_OPENMP=ON)
540+
-DLLVM_RUNTIME_OPENMP=ON
541+
${extra_cmake_args})
539542
set(HSA_DEP rocr-runtime)
540543
endif()
541544

@@ -549,9 +552,9 @@ if(build_runtimes)
549552
SOURCE_DIR ${LIBOMPTARGET_EXTERNAL_PROJECT_ROCM_DEVICE_LIBS_PATH}
550553
DEPENDS clang llvm-link lld opt llvm-objcopy
551554
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${ROCM_DEVICE_LIBS_INSTALL_PREFIX_PATH}
552-
-DCMAKE_PREFIX_PATH=${CMAKE_BINARY_DIR}/lib/cmake
553555
-DROCM_DEVICE_LIBS_BITCODE_INSTALL_LOC_NEW=${ROCM_DEVICE_LIBS_BITCODE_INSTALL_LOC}
554-
-DROCM_DEVICE_LIBS_BITCODE_INSTALL_LOC_OLD=amdgcn)
556+
-DROCM_DEVICE_LIBS_BITCODE_INSTALL_LOC_OLD=amdgcn
557+
${extra_cmake_args})
555558
else()
556559
ExternalProject_Add(rocm-device-libs
557560
SOURCE_DIR ${LIBOMPTARGET_EXTERNAL_PROJECT_ROCM_DEVICE_LIBS_PATH}

0 commit comments

Comments
 (0)