Skip to content

Commit 64f0faa

Browse files
authored
Merge pull request llvm#398 from AMD-Lightning-Internal/amd/dev/jlambert/mainline-spirv-check
Amd/dev/jlambert/mainline spirv check
2 parents 8e6ca11 + 2e53d00 commit 64f0faa

File tree

1 file changed

+22
-7
lines changed

1 file changed

+22
-7
lines changed

amd/comgr/CMakeLists.txt

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
cmake_minimum_required(VERSION 3.13.4)
22

3+
include(CheckIncludeFileCXX)
4+
35
file(READ "VERSION.txt" comgr_ver_file)
46

57
string(REGEX MATCH "#COMGR_VERSION_MAJOR\n([0-9]*)" _ ${comgr_ver_file})
@@ -169,16 +171,31 @@ set(AMD_COMGR_PRIVATE_COMPILE_DEFINITIONS ${LLVM_DEFINITIONS})
169171
set(AMD_COMGR_PUBLIC_LINKER_OPTIONS)
170172
set(AMD_COMGR_PRIVATE_LINKER_OPTIONS)
171173

174+
list(APPEND AMD_COMGR_PRIVATE_COMPILE_DEFINITIONS "AMD_COMGR_GIT_COMMIT=${AMD_COMGR_GIT_COMMIT}")
175+
list(APPEND AMD_COMGR_PRIVATE_COMPILE_DEFINITIONS "AMD_COMGR_GIT_BRANCH=${AMD_COMGR_GIT_BRANCH}")
176+
message("----COMGR_GIT_COMMIT: ${AMD_COMGR_GIT_COMMIT}")
177+
message("----COMGR_GIT_BRANCH: ${AMD_COMGR_GIT_BRANCH}")
178+
message("")
179+
172180
option(COMGR_DISABLE_SPIRV "To disable SPIRV in Comgr" OFF)
181+
182+
if (NOT COMGR_DISABLE_SPIRV)
183+
# TODO: Explore switching this to CHECK_INCLUDE_FILE_CXX() macro
184+
if (NOT EXISTS "${LLVM_INCLUDE_DIRS}/LLVMSPIRVLib/LLVMSPIRVLib.h")
185+
message("-- LLVMSPIRVLib/LLVMSPIRVLib.h not found")
186+
set(COMGR_DISABLE_SPIRV ON)
187+
else()
188+
message("-- LLVMSPIRVLib/LLVMSPIRVLib.h found")
189+
endif()
190+
endif()
191+
173192
if(${COMGR_DISABLE_SPIRV})
174193
list(APPEND AMD_COMGR_PRIVATE_COMPILE_DEFINITIONS "COMGR_DISABLE_SPIRV")
194+
message("-- Comgr SPIRV Disabled")
195+
else()
196+
message("-- Comgr SPIRV Enabled")
175197
endif()
176198

177-
list(APPEND AMD_COMGR_PRIVATE_COMPILE_OPTIONS "-DAMD_COMGR_GIT_COMMIT=${AMD_COMGR_GIT_COMMIT}")
178-
list(APPEND AMD_COMGR_PRIVATE_COMPILE_OPTIONS "-DAMD_COMGR_GIT_BRANCH=${AMD_COMGR_GIT_BRANCH}")
179-
message("----COMGR_GIT_COMMIT: ${AMD_COMGR_GIT_COMMIT}")
180-
message("----COMGR_GIT_BRANCH: ${AMD_COMGR_GIT_BRANCH}")
181-
message("")
182199

183200
if (UNIX)
184201
list(APPEND AMD_COMGR_PRIVATE_COMPILE_OPTIONS
@@ -392,11 +409,9 @@ set(LLD_LIBS
392409
lldCommon)
393410

394411
if (${COMGR_DISABLE_SPIRV})
395-
message("-- Comgr SPIRV Disabled")
396412
set(SPIRV_DYNAMIC_LIB "")
397413
set(SPIRV_STATIC_LIB "")
398414
else()
399-
message("-- Comgr SPIRV Enabled")
400415
set(SPIRV_DYNAMIC_LIB "LLVMSPIRVAMDLib")
401416
set(SPIRV_STATIC_LIB "SPIRVAMDLib")
402417
endif()

0 commit comments

Comments
 (0)