Skip to content

Commit 6765fd3

Browse files
committed
Reland "735a5f67e351 [AMDGPU] When allocating VGPRs, VGPR spills are not part of the prologue (llvm#109439)"
This is supposed to be fixed by llvm@6636f32. More context: https://ontrack-internal.amd.com/browse/SWDEV-489621 Change-Id: I49ec81989eec8fda897dffb1bd7b4dbb76a98c46
1 parent 0197783 commit 6765fd3

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

llvm/lib/Target/AMDGPU/SIInstrInfo.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8953,11 +8953,10 @@ bool SIInstrInfo::isBasicBlockPrologue(const MachineInstr &MI,
89538953
}
89548954

89558955
uint16_t Opcode = MI.getOpcode();
8956-
// FIXME: Copies inserted in the block prolog for live-range split should also
8957-
// be included.
89588956
return IsNullOrVectorRegister &&
8959-
(isSpill(Opcode) || (!MI.isTerminator() && Opcode != AMDGPU::COPY &&
8960-
MI.modifiesRegister(AMDGPU::EXEC, &RI)));
8957+
(isSGPRSpill(Opcode) ||
8958+
(!MI.isTerminator() && Opcode != AMDGPU::COPY &&
8959+
MI.modifiesRegister(AMDGPU::EXEC, &RI)));
89618960
}
89628961

89638962
MachineInstrBuilder

revert_patches.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,6 @@ Revert "Recommit "[InstCombine] Expand `foldSelectICmpAndOr` -> `foldSelectICmpA
7979
This reverts commit 54ec8bcaf85e3a3341c97640331d58e24ac0d2cd.
8080
contact: Selehov
8181
---
82-
hangs ocl at -O0
83-
735a5f67e351 [AMDGPU] When allocating VGPRs, VGPR spills are not part of the prologue (#109439)
84-
Ron,MatC,Jay
85-
---
8682
breaks hip_on_rocclr build
8783
Revert 8039886e6d "AMDGPU: Handle folding frame indexes into s_add_i32 (#101694)"
8884
Ron/MatC

0 commit comments

Comments
 (0)