[Comgr] Make VFS default

Currently this only affects device library linking

Author: chinmaydd

amd/comgr/README.md

@@ -198,13 +198,11 @@ improving performance by reducing on-disk file I/O. Currently, VFS is only suppo
 for the device library link step, but we aim to progressively add support for
 more actions.
 
-By default, VFS is turned off. Set the environment variable `AMD_COMGR_USE_VFS=1` to 
-enable it.
+By default, VFS is turned on.
 
-* `AMD_COMGR_USE_VFS`: When unset or "0", VFS support is turned off.
-* Users may use the API `amd_comgr_action_info_set_vfs` to enable VFS for individual actions
-  without having to modify system-wide environment variables. Note that API is effective only 
-  if `AMD_COMGR_USE_VFS` is unset.
+* `AMD_COMGR_USE_VFS`: When set to "0", VFS support is turned off.
+* Users may use the API `amd_comgr_action_info_set_vfs` to disable VFS for individual actions
+  without having to modify system-wide environment variables.
 * If `AMD_COMGR_SAVE_TEMPS` is set and not "0", VFS support is turned off irrespective
   of `AMD_COMGR_USE_VFS` or the use of `amd_comgr_action_info_set_vfs`.
 

amd/comgr/docs/ReleaseNotes.md

@@ -38,8 +38,9 @@ Bug Fixes
 New APIs
 --------
 - amd\_comgr\_info\_set\_vfs\_() (v3.1)
-    - By setting this ActionInfo property, a user can explicitly dictate if
-    device libraries should be linked using a Virtual File System (VFS).
+    - By setting this ActionInfo property, users can explicitly dictate if
+    device libraries should be linked using the real file system or a
+    Virtual File System (VFS).
 
 Deprecated APIs
 ---------------

amd/comgr/src/comgr.h

@@ -204,7 +204,7 @@ struct DataAction {
   amd_comgr_language_t Language;
   bool Logging;
   bool ShouldLinkDeviceLibs = false;
-  bool ShouldUseVFS = false;
+  bool ShouldUseVFS = true;
 
   std::vector<std::string> BundleEntryIDs;
 

amd/comgr/test-lit/vfs-tests/vfs-tests.cl

@@ -23,7 +23,7 @@
 // COM: Verify success of compilation for all scenarios
 // STATUS: ReturnStatus: AMD_COMGR_STATUS_SUCCESS
 
-// OUT-NA-NA-NA: File System: Real
+// OUT-NA-NA-NA: File System: VFS
 // OUT-NA-VFS-NOVFS: File System: VFS
 // OUT-NA-VFS-NA: File System: VFS
 // OUT-NA-NOVFS-VFS: File System: Real