[NFC] [AST] Introduce Decl::isInAnotherModuleUnit and Decl::shouldEmitInExternalSource

Motivated by the review process in
llvm#75912. This can also help to
simplify the code slightly.

Change-Id: Iffc556c1390a8365a8ffe598e94d3ad2ea83582c

Author: ChuanqiXu9

clang/lib/AST/ASTContext.cpp

@@ -3969,7 +3969,6 @@ QualType ASTContext::getConstantArrayType(QualType EltTy,
   llvm::APInt ArySize(ArySizeIn);
   ArySize = ArySize.zextOrTrunc(Target->getMaxPointerWidth());
 
-
   llvm::FoldingSetNodeID ID;
   ConstantArrayType::Profile(ID, *this, EltTy, ArySize.getZExtValue(), SizeExpr,
                              ASM, IndexTypeQuals);

clang/lib/CodeGen/CGVTables.cpp

@@ -803,8 +803,7 @@ void CodeGenVTables::addVTableComponent(ConstantArrayBuilder &builder,
       // For NVPTX devices in OpenMP emit special functon as null pointers,
       // otherwise linking ends up with unresolved references.
       if (CGM.getLangOpts().OpenMP && CGM.getLangOpts().OpenMPIsTargetDevice &&
-          (CGM.getTriple().isNVPTX() ||
-           (CGM.getTriple().isAMDGCN())))
+          CGM.getTriple().isNVPTX())
         return llvm::ConstantPointerNull::get(CGM.GlobalsInt8PtrTy);
       llvm::FunctionType *fnTy =
           llvm::FunctionType::get(CGM.VoidTy, /*isVarArg=*/false);

revert_patches.txt

@@ -2,13 +2,6 @@ revert: breaks MIOpen composableKernel build
 [clang][Sema] Add -Wswitch-default warning option (#73077)  
    https://ontrack-internal.amd.com/browse/SWDEV-436625
 
-Revert: breaks build of hipCUB
-commit 55783bd0 [HIP] fix host min/max in header (#82956)
-
-Revert :breaks hip catch tests.
-1de7e6c8cba2 [clang] move -Wcast-function-type under -Wextra (#77178)
-999d4f840777 Split -Wcast-function-type into a separate group (#86131)   
-
 ---
 Revert: 8009bbe
   Commit title:
@@ -47,30 +40,10 @@ Revert: 41f9c78
   Contacts:
     Konstantin
 ---
-
-Revert "Recommit "[InstCombine] Expand `foldSelectICmpAndOr` -> `foldSelectICmpAndBinOp` to work for more binops" (3rd Try)"
-
-    Backup fix for SWDEV-454675
-
-    This reverts commit 54ec8bcaf85e3a3341c97640331d58e24ac0d2cd.
-
-contact: Selehov
-
----
-Revert: breaks ipBlender*
-0e73bbd3450c   [AMDGPU][PromoteAlloca] Don't stop when an alloca is too big to promote (#93466) 
-
-contact: Pierre
-
----
 Revert: temaplate breaks ComposableKernel build
 f46d1463b835 [clang] require template arg list after template kw (#80801) 
 contact : RonL
 ---
-Revert: Breaks check-clang test 'clang/test/Modules/pr60085.cppm'
-99873b35da7e [NFC] [AST] Introduce Decl::isInAnotherModuleUnit and Decl::shouldEmitInExternalSource
-contact : mhalk (Michael Halkenhaeuser)
----
 Revert:  breaks composableKernel
 53d2f4d96783 [CUDA][HIP] warn incompatible redeclare (#77359)     
 contact : Ronl or Sam
@@ -95,6 +68,8 @@ Revert: more Sema:
 9e1f1cfa59c4 [Clang][Sema] Handle class member access expressions with valid nested-name-specifiers that become invalid after lookup (#98167)
 RonL
 ---
+============== above are sema/mipopen/composable-kernel related
+---
 Revert: breaks devIO for openmp
 dfeb3991fb48 Remove the `x86_mmx` IR type. (#98505)
 b7e4fba6e5dc Cleanup x86_mmx after removing IR type  (#100646) (Reason: dependent on dfeb3991fb48)
@@ -105,3 +80,19 @@ revert:  1ca9fe6db334  Reapply "[Attributor][AMDGPU] Enable AAIndirectCallInfo f
 revert : breaks build of amdgpu flat intrinsics
 ee08d9cba561 AMDGPU: Remove global/flat atomic fadd intrinics (#97051) 
 ---
+Revert: breaks build of hipCUB
+commit 55783bd0 [HIP] fix host min/max in header (#82956)
+---
+Revert :breaks hip catch tests.
+1de7e6c8cba2 [clang] move -Wcast-function-type under -Wextra (#77178)
+999d4f840777 Split -Wcast-function-type into a separate group (#86131)   
+---
+Revert "Recommit "[InstCombine] Expand `foldSelectICmpAndOr` -> `foldSelectICmpAndBinOp` to work for more binops" (3rd Try)"
+    Backup fix for SWDEV-454675
+    This reverts commit 54ec8bcaf85e3a3341c97640331d58e24ac0d2cd.
+contact: Selehov
+---
+Revert: breaks hipBlender*
+0e73bbd3450c   [AMDGPU][PromoteAlloca] Don't stop when an alloca is too big to promote (#93466) 
+contact: Pierre
+---