Disable flang warning, its erroneously firing on all uses (llvm#2546)

Author: ronlieb

clang/lib/Driver/ToolChain.cpp

@@ -503,7 +503,8 @@ ToolChain::getTargetAndModeFromProgramName(StringRef PN) {
   // the time being and should be removed once AMD Classic Flang has been
   // removed from ROCm.
   if (FlangNew) {
-    if (!::getenv("AMD_NOWARN_FLANG_NEW")) {
+    // flang-new warning is overwarning, disabling until fixed.
+    if (false && !::getenv("AMD_NOWARN_FLANG_NEW")) {
       // The solution with "llvm::errs()" is not ideal, but the driver object
       // is not been constructed yet, so we cannot use the Diag() infrastructure
       // for this.

flang/test/Driver/flang-new-warning.f90

@@ -1,2 +1,3 @@
 ! RUN: amdflang-new -c %s 2>&1 | FileCheck %s
-! CHECK: warning: the 'amdflang-new' and 'flang-new' commmands have been deprecated; please use 'amdflang' instead
+! CHECK: warning: the 'amdflang-new' and 'flang-new' commmands have been deprecated; please use 'amdflang' instead
+! XFAIL: *

flang/test/Driver/w-option.f90

@@ -1,4 +1,3 @@
-! XFAIL: *
 ! Test the default setting. Emit warnings only.
 ! RUN: %flang -c %s 2>&1 | FileCheck %s -check-prefix=DEFAULT