Skip to content

Commit 7f91d05

Browse files
committed
remove redundant flag, update tests
1 parent 0d53abd commit 7f91d05

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

amd/comgr/src/comgr-compiler.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1922,7 +1922,6 @@ static inline const std::unordered_set<std::string_view> ValidSpirvFlags{
19221922
"-fno-signed-zeros",
19231923
"-fno-threadsafe-statics",
19241924
"-freciprocal-math",
1925-
"-fskip-odr-check-in-gmf",
19261925
"-funsafe-math-optimizations",
19271926
"-fvisibility=hidden",
19281927
"-gheterogeneous-dwarf=diexpression",

amd/comgr/test-lit/spirv-to-reloc.hip

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
// CHECK: SPIR-V Translation: amd-llvm-spirv -r --spirv-target-env=CL2.0 {{.*}}
1717

1818
// COM: Check that SPIR-V flags are correctly extracted
19-
// CHECK: Driver Job Args: {{.*}} "-fno-rounding-math" "-O3" "-fno-autolink" "-fvisibility=hidden" "-fexceptions" "-fcolor-diagnostics" "-mcode-object-version=5"
19+
// CHECK: Driver Job Args: {{.*}} "-fno-rounding-math" "-fno-threadsafe-statics" "-O3" "-fno-autolink" "-fvisibility=hidden" "-fexceptions" "-fcolor-diagnostics" "-mcode-object-version=5"
2020

2121
// COM: ----
2222
// COM: Generate a debuginfo SPIR-V file from a HIP kernel
@@ -31,7 +31,6 @@
3131
// COM: Check that debuginfo SPIR-V flags are correctly extracted
3232
// CHECK-DBG: Driver Job Args: {{.*}} "-gheterogeneous-dwarf=diexpression" "-mllvm -amdgpu-spill-cfi-saved-regs"
3333

34-
3534
#include <cstdlib>
3635

3736
#define __constant__ __attribute__((constant))

0 commit comments

Comments
 (0)