Skip to content

Commit 85943e3

Browse files
committed
Address comments
1 parent dcc6421 commit 85943e3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

offload/plugins-nextgen/amdgpu/src/rtl.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2235,8 +2235,8 @@ struct AMDGPUStreamTy {
22352235
}
22362236
}
22372237

2238-
// When LIBOMPTARGET_EXE_TIME is set, register the callback function to get
2239-
// the kernel duration.
2238+
// When LIBOMPTARGET_KERNEL_EXE_TIME is set, register the callback function
2239+
// to get the kernel duration.
22402240
if (Device.enableKernelDurationTracing()) {
22412241
KernelDurationTracingArgs.Agent = Agent;
22422242
KernelDurationTracingArgs.Signal = OutputSignal;
@@ -2689,8 +2689,8 @@ struct AMDGPUStreamManagerTy final
26892689
OMPX_EnableQueueProfiling("LIBOMPTARGET_AMDGPU_ENABLE_QUEUE_PROFILING",
26902690
false),
26912691
NextQueue(0), Agent(HSAAgent) {
2692-
// If OMPX_ENABLE_RUNTIME_AUTOTUNING or LIBOMPTARGET_EXE_TIME is enabled,
2693-
// set queue profiling to true.
2692+
// If OMPX_ENABLE_RUNTIME_AUTOTUNING or LIBOMPTARGET_KERNEL_EXE_TIME is
2693+
// enabled, set queue profiling to true.
26942694
if (Device.enableRuntimeAutotuning() ||
26952695
Device.enableKernelDurationTracing()) {
26962696
OMPX_EnableQueueProfiling = true;

offload/plugins-nextgen/common/src/PluginInterface.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ GenericDeviceTy::GenericDeviceTy(GenericPluginTy &Plugin, int32_t DeviceId,
947947
OMPX_InitialNumEvents("LIBOMPTARGET_NUM_INITIAL_EVENTS", 1),
948948
OMPX_NumMultiDevices("LIBOMPTARGET_NUM_MULTI_DEVICES", 0),
949949
OMPX_EnableRuntimeAutotuning("OMPX_ENABLE_RUNTIME_AUTOTUNING", false),
950-
OMPX_KernelDurationTracing("LIBOMPTARGET_EXE_TIME", false),
950+
OMPX_KernelDurationTracing("LIBOMPTARGET_KERNEL_EXE_TIME", false),
951951
DeviceId(DeviceId), GridValues(OMPGridValues),
952952
PeerAccesses(NumDevices, PeerAccessState::PENDING), PeerAccessesLock(),
953953
PinnedAllocs(*this), RPCServer(nullptr), KernelRunRecords(nullptr) {

0 commit comments

Comments
 (0)